-
Notifications
You must be signed in to change notification settings - Fork 550
Fix TypeError in unsloth_push_to_hub_gguf() when pushing GGUF model to Hugging Face #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… argument 'repo_id' when tried to push GGUF version to HuggingFace
Summary of ChangesHello @samanta-sc, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical TypeError that previously prevented GGUF models from being successfully uploaded to Hugging Face via the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully addresses the TypeError in unsloth_push_to_hub_gguf() by removing the duplicate repo_id argument. The fix is applied consistently across numerous Jupyter notebooks and Python scripts. The PR also includes widespread cosmetic updates, such as fixing emoji rendering and character encoding in the notebook files. I've identified a small typo in the repo_id string within two of the updated notebook files and have provided suggestions to correct them. Otherwise, the changes look good and effectively resolve the reported issue.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
I can confirm that this is working even in Colab. Thank you so much for the PR |
This pull request fixes a TypeError that occurred when attempting to push the GGUF model version to Hugging Face using:
The issue was caused by duplicate argument handling for repo_id. This update adjusts the function call so that parameters are passed correctly, preventing the conflict.
After applying the fix, the GGUF model upload process works smoothly without any errors.
Key changes:
Fixed duplicate
repo_idargument handling inunsloth_push_to_hub_gguf()Verified successful GGUF model push to Hugging Face Hub.
Impact:
This resolves the upload issue for GGUF models and improves reliability for anyone pushing model variants to Hugging Face.
Thanks:
Appreciate the review! Hopefully this helps others who encountered the same TypeError when using the GGUF push function.