Skip to content

Conversation

@samanta-sc
Copy link
Contributor

This pull request fixes a TypeError that occurred when attempting to push the GGUF model version to Hugging Face using:

unsloth_push_to_hub_gguf() got multiple values for argument 'repo_id'

The issue was caused by duplicate argument handling for repo_id. This update adjusts the function call so that parameters are passed correctly, preventing the conflict.

After applying the fix, the GGUF model upload process works smoothly without any errors.

Key changes:

  • Fixed duplicate repo_id argument handling in unsloth_push_to_hub_gguf()

  • Verified successful GGUF model push to Hugging Face Hub.

Impact:
This resolves the upload issue for GGUF models and improves reliability for anyone pushing model variants to Hugging Face.

Thanks:
Appreciate the review! Hopefully this helps others who encountered the same TypeError when using the GGUF push function.

… argument 'repo_id' when tried to push GGUF version to HuggingFace
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @samanta-sc, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical TypeError that previously prevented GGUF models from being successfully uploaded to Hugging Face via the unsloth_push_to_hub_gguf() function. The issue stemmed from an incorrect duplication of the repo_id argument. By streamlining the function call to pass repo_id only once as a positional argument, this change significantly enhances the reliability of the GGUF model export process across multiple notebooks and scripts.

Highlights

  • Fix TypeError in GGUF model push: Resolved a TypeError that occurred when using unsloth_push_to_hub_gguf() to push GGUF models to Hugging Face, caused by duplicate repo_id argument handling.
  • Improved GGUF model upload reliability: The fix ensures correct parameter passing to the unsloth_push_to_hub_gguf() function, leading to successful GGUF model uploads without errors.
  • Notebook and script updates: Various Jupyter notebooks and Python scripts were updated to reflect the corrected model.push_to_hub_gguf() function signature, removing the redundant repo_id keyword argument.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully addresses the TypeError in unsloth_push_to_hub_gguf() by removing the duplicate repo_id argument. The fix is applied consistently across numerous Jupyter notebooks and Python scripts. The PR also includes widespread cosmetic updates, such as fixing emoji rendering and character encoding in the notebook files. I've identified a small typo in the repo_id string within two of the updated notebook files and have provided suggestions to correct them. Otherwise, the changes look good and effectively resolve the reported issue.

samanta-sc and others added 2 commits November 9, 2025 09:44
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@Erland366
Copy link
Collaborator

Erland366 commented Nov 10, 2025

I can confirm that this is working even in Colab. Thank you so much for the PR

@Erland366 Erland366 merged commit 786d348 into unslothai:main Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants