-
Notifications
You must be signed in to change notification settings - Fork 550
gemma3-270m: reduce batch size for sample packing #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @djsaunde, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses potential Out-Of-Memory issues during the training of the Gemma3-270M model, particularly when using sample packing. By halving the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Summary of ChangesHello @djsaunde, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses potential Out-of-Memory (OOM) issues encountered during the training of the Gemma3-270M model, particularly when sample packing is enabled. By halving the training batch size, the changes aim to reduce the memory footprint during model training, thereby preventing OOM errors and ensuring more stable and successful training runs for this specific model configuration. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request reduces the per_device_train_batch_size from 8 to 4 for the Gemma3-270M model to prevent out-of-memory errors. This is a sensible change. My review includes a suggestion to also increase gradient_accumulation_steps from 1 to 2 in both the notebook and the Python script. This would maintain the original effective batch size of 8, which is often beneficial for training stability, while still achieving the goal of lower memory usage per step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request reduces the per_device_train_batch_size from 8 to 4 for the Gemma3-270M model in both the Jupyter notebook and the corresponding Python script. This change is intended to prevent out-of-memory errors when using sample packing. My review suggests an improvement: to maintain the original effective batch size of 8, you could also update gradient_accumulation_steps to 2. This would preserve the training dynamics while still achieving the memory reduction benefits.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Quoting myself:
This applies to the Gemma3-270M notebook in particular; hence the change from batch size 8 -> 4 here.
To be merged with unslothai/unsloth#3566.