-
Notifications
You must be signed in to change notification settings - Fork 550
fix magistral inference #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @rolandtannous, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical issue preventing successful inference in the Magistral notebook. The changes ensure that the multimodal processor correctly interprets chat messages, resolving a Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes an issue with Magistral model inference by updating how the tokenizer is called. The changes in the Python scripts are correct. However, the same changes in the Jupyter Notebook files (.ipynb) introduce a syntax error due to missing commas between function arguments. I've added critical comments to address this in each of the affected notebook files.
Problem
Trying to run the inference cell in the original Magistral notebook resulted in
The failing code was:
The Magistral-Small-2509 model uses a PixtralProcessor (multimodal processor), not a standard tokenizer. When you call tokenizer(text, ...) directly, the processor tries to parse the input for both text and images. Since text is a long string, the processor interprets it as a potential image URL/path and attempts to load it as an image, causing the error.
Solution
we don't call the processor directly on the formatted text string. Instead, pass the messages directly to apply_chat_template with tokenize=True.
Also , the PixtralProcessor is designed for multimodal inputs (text + images). It expects message["content"] to be a list of content blocks, where each block is a dictionary with a "type" . When we pass a plain string like "content": "Solve (x + 2)^2 = 0.", the processor tries to iterate over the string characters and access content["type"], which fails because string indices must be integers. So we should also make sure to structure the content as a list of content block dictionaries.
The final revised code is as follows: