GH-127: Add PR label check #222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcombs15
force-pushed
the
feature/GH-127-check-pr-labels
branch
from
843533a to
5609cf2
Compare
lcombs15
added
the
no-release
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #222 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 160 160
=========================================
Hits 160 160 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lcombs15
added
Patch
lcombs15
force-pushed
the
feature/GH-127-check-pr-labels
branch
2 times, most recently
from
524258d to
5c19763
Compare
lcombs15
added
no-release
lcombs15
force-pushed
the
feature/GH-127-check-pr-labels
branch
6 times, most recently
from
a61a800 to
9a64af6
Compare
lcombs15
added
Major
lcombs15
added
the
no-release
lcombs15
commented
Sep 14, 2025
| shell: bash | ||
| - name: Prepare Scripts | ||
| run: | | ||
| chmod +x scripts/* |
Member
Author
There was a problem hiding this comment.
I think we'd need this if we were calling ./scripts/lint.py rather than python scripts/lint.pt
One less thing to read in this file
lcombs15
commented
Sep 14, 2025
| * Please submit an issue with the terminal output you received [here](https://github.com/unthreaded/git-hooks/issues) with as much detail as possible. | ||
|
|
||
| ## Development details | ||
| For Mac, you must install some dependencies via brew. Simply run [`os_specific_requirements.py`](scripts/os_specific_requirements.py) and you'll be good to go! |
Member
Author
There was a problem hiding this comment.
A couple weeks ago I was reading this: https://pyinstaller.org/en/stable/usage.html#using-upx
Turns out PyInstaller no longer references this UPX is currently used only on Windows.
lcombs15
force-pushed
the
feature/GH-127-check-pr-labels
branch
from
cdf3c7a to
ad8005c
Compare
tiemonl
approved these changes
Sep 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Issue
Closes #127
📝 Details
Added a label check! Also cleaned up actions some.