Skip to content

Umcs 56/fix/test logging #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 1, 2021
Merged

Umcs 56/fix/test logging #21

merged 3 commits into from
Feb 1, 2021

Conversation

@Ryouzanpaku
Copy link
Contributor

@Ryouzanpaku Ryouzanpaku commented Jan 18, 2021 •
edited
Loading

  • fix debug logging not behave as expected on failing test that depend on another test.
  • Use correct variable in installment example.

@Ryouzanpaku
[fix] (UMCS-56)
d8d0638 
- tests: Failed tests which depend on another test did not log debug messages as expected, when debug mode has been disabled.
@Ryouzanpaku
[fix] (UMCS-56)
fec06c5 
- update changelog
- correct charge variable in installment example.
@Ryouzanpaku
[fix] (UMCS-56)
20c414c 
- code style.
@Ryouzanpaku Ryouzanpaku merged commit 383aacf into develop Feb 1, 2021
@Ryouzanpaku Ryouzanpaku deleted the UMCS-56/fix/test-logging branch March 1, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sixer1182 sixer1182 sixer1182 approved these changes

@kevinvn1709 kevinvn1709 Awaiting requested review from kevinvn1709

+1 more reviewer

@DerAusHeidelberg DerAusHeidelberg DerAusHeidelberg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Ryouzanpaku @sixer1182 @DerAusHeidelberg