Smart Textarea: Add new component #554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aprentout
commented
Aug 18, 2025
| <span class="hidden-span"> | ||
| {{if (or this.inputValue this.isInputFocused) this.inputValue this.placeholder}} | ||
| </span> | ||
| <span class="hidden-span">{{this.hiddenSpanValue}}</span> |
Contributor
Author
There was a problem hiding this comment.
🥷 Remove span strange escape, which lead to unconsistent behavior between classic & loading state
nathalieArnoux
approved these changes
Aug 18, 2025
app/styles/atoms/smart-textarea.less
Outdated
| .oss-textarea-container; | ||
| flex: 1; | ||
| // max-width: fit-content; | ||
| // width: 100%; |
|
|
||
| hooks.beforeEach(function () { | ||
| this.value = 'Data'; | ||
|
|
Contributor
There was a problem hiding this comment.
can remove the linebreak here
OwenCoogan
approved these changes
Aug 20, 2025
addon/components/o-s-s/text-area.ts
Outdated
| return this.args.rows || 2; | ||
| } | ||
|
|
||
| get resize(): 'vertical' | 'horizontal' | 'none' | undefined { |
Contributor
There was a problem hiding this comment.
Nit but we might export the resize types from the parent component & import it in the extended component
|
|
||
| @action | ||
| onTextAreaChange(value: string): void { | ||
| console.log('Text area value changed:', value); |
Contributor
Author
There was a problem hiding this comment.
It's in dummy app :)
upfluence-bot
added
reviewed/ready-to-merge
reviewed/needs-work
and removed
reviewed/needs-review
reviewed/ready-to-merge
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Related to: #DRA-3516
What are the observable changes?
Add new OSS::Smart::Textarea component :)
Enregistrement.de.l.ecran.2025-08-18.a.15.34.44.mov
Good PR checklist