perf: improve code and refactoring props #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nd0ut
reviewed
Mar 28, 2024
| }) => { | ||
| const CTX_NAME = useMemo(() => LR.UID.generate(), [LR.UID.generate]); | ||
| const CTX_NAME = useMemo( | ||
| () => ctxName ?? LR.UID.generate(), |
There was a problem hiding this comment.
Probably we need to store random uid in the ref to avoid uid change in the strict dev mode. AFAIK useMemo will be called twice in this case
nd0ut
reviewed
Mar 28, 2024
| 'className', | ||
| ]) | ||
| "children", | ||
| "localName", |
egordidenko
force-pushed
the
perf/react-adapter-and-uploader
branch
from
586e3ea to
7a6f021
Compare
egordidenko
force-pushed
the
perf/react-adapter-and-uploader
branch
from
7a6f021 to
98c8638
Compare
nd0ut
approved these changes
Mar 28, 2024
nd0ut
pushed a commit
that referenced
this pull request
Mar 28, 2024
feat(react-uploader): added types for build (#3) * feat(react-uploader): added types for build * feat(react-uploader): added types refUploadCtxProvider (opt) * feat: added partial types config/events * feat: export UploadCtxProvider * feat(react-uploader): added README.md feat: added blocks alpha versions (#2) Perf/props events ctx (#1) * feat(react-uploader): removed from props ctxName, ctxCssSrc * feat(react-adapter): removed unused dependency * perf(react-uploader): improved and simplified receiving events from props * feat(react-uploader): added memo for ctxName * feat(react-adapter): added types for build * feat(react-uploader): remove @ts-ignore * feat: added vite-plugin-dts feat: added LICENSE feat: added common README.md feat: implement react component and adapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist