Skip to content

Passes full object to readonly function on a cell #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2018
Merged

Passes full object to readonly function on a cell #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/object-cell.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,11 @@ class ObjectCell extends React.Component {
handleDoubleClick = (event) => {
this.beginEdit()
}
editable(objectId) {
return cellIsEditable(objectId, this.props.column)
editable(object) {
return cellIsEditable(object, this.props.column)
}
beginEdit = (editReplaceOverride) => {
if (!this.props.disabled && this.editable(this.getCellRef().objectId)) {
if (!this.props.disabled && this.editable(this.props.object)) {
this.props.beginEdit(this.getCellRef(), editReplaceOverride)
}
}
Expand Down Expand Up @@ -137,7 +137,7 @@ class ObjectCell extends React.Component {

let cellProps = {
className: classNames(classes + ' drawer ' + drawer.className, {
uneditable: (!this.editable(this.getCellRef().objectId)),
uneditable: (!this.editable(this.props.object)),
}),
}
if (!this.props.column.disableInteraction) {
Expand Down
4 changes: 2 additions & 2 deletions src/utilities.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ function dictFirstKey(dict) {
return undefined
}

function cellIsEditable(objectId, column) {
function cellIsEditable(object, column) {
const { isReadOnly, editor } = column
const editorIsSet = editor !== false
const readOnly = typeof isReadOnly === 'function' ? isReadOnly(objectId) : (isReadOnly === true)
const readOnly = typeof isReadOnly === 'function' ? isReadOnly(object) : (isReadOnly === true)
return editorIsSet && !readOnly
}

Expand Down