feature: replacing webpack with esbuild. #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreadera
changed the title
mwfister
approved these changes
Jun 8, 2021
Comment on lines
+1
to
+4
| import ObjectTable, { ObjectCell, ObjectRow, BaseEditor, TextEditor, TextDrawer } from './object-table' | ||
|
|
||
| export default ObjectTable | ||
| export { ObjectCell, ObjectRow, BaseEditor, TextEditor, TextDrawer } No newline at end of file |
Contributor
There was a problem hiding this comment.
Is this change tackling this comment? If it is, maybe add a comment linking these PRs for posterity
Contributor
Author
There was a problem hiding this comment.
Yes it does tackle it and for sure I will :)
Contributor
Author
|
This building method also tackles the issues I was having with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will be updating this library to use
esbuildas part of trying to modernise our libraries.I have broken down each commit into a section I have worked on.
Changelog
esbuild.webpack.babel.esmModule support Added.eslintdependencies & rules.