fix(crawl): drop redundant .into_iter() for clippy 1.95#39
Merged
Conversation
`stream::iter` accepts any `IntoIterator`, so the explicit `.into_iter()` on `batch` triggers `clippy::useless_conversion` under Rust 1.95 (CI was red on main after the #33 sitemap fix; local Rust 1.94 didn't flag it).
There was a problem hiding this comment.
Pull request overview
This PR fixes CI failures on Rust 1.95 by removing a redundant .into_iter() call when building a stream from a Vec, addressing clippy::useless_conversion in the sitemap crawl BFS.
Changes:
- Remove explicit
.into_iter()when passingbatchtofutures::stream::iter, relying onIntoIteratorinference instead.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes red CI on main.
stream::iteraccepts anyIntoIterator, so the explicit.into_iter()onbatchtriggersclippy::useless_conversionunder Rust 1.95.0 (CI's toolchain). Local Rust 1.94.1 didn't flag it, which is how it slipped through #33's merge.Trivial one-line fix; tests still green.