PHP-FPM translate Kill Signals #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vox-eve
requested review from
WyriHaximus,
agustingomes,
cvmiert,
fabiotc,
frankkoornstra and
rdohms
frankkoornstra
approved these changes
Apr 18, 2019
Contributor
frankkoornstra
left a comment
frankkoornstra
left a comment
There was a problem hiding this comment.
What do the rewrites do?
renatomefi
force-pushed
the
php-fpm/translate-signals
branch
from
a2dbf84 to
869af61
Compare
Now we can rely on correct signal handling via dumb-init and only use shush when there's actually encrypted variables
renatomefi
force-pushed
the
php-fpm/translate-signals
branch
from
869af61 to
15c6f8e
Compare
Contributor
Author
|
@frankkoornstra |
lcobucci
added a commit
to lcobucci/php
that referenced
this pull request
Apr 18, 2019
The default signal used by docker to stop a container is SIGTERM and that signal is understood by PHP-FPM as immediate termination. This means that `php-fpm` won't wait for in-flight requests to finish before of stopping the workers and main process. This behaviour is quite undesired for production environments and should be avoided as much as possible. This implementation is meant to be extremely simple and only address the stop signal used when running `docker stop`. `php-fpm` signal choices are somewhat peculiar (`SIGUSR2` for example) and if we want to "fix" them we would have to use a tool (e.g.: `dumb-init`). More info: - https://linux.die.net/man/8/php-fpm - https://docs.docker.com/engine/reference/builder/#stopsignal - https://github.com/Yelp/dumb-init - usabilla/php-docker-template#102
ReactDevs007
added a commit
to ReactDevs007/dockerlib
that referenced
this pull request
Feb 3, 2021
The default signal used by docker to stop a container is SIGTERM and that signal is understood by PHP-FPM as immediate termination. This means that `php-fpm` won't wait for in-flight requests to finish before of stopping the workers and main process. This behaviour is quite undesired for production environments and should be avoided as much as possible. This implementation is meant to be extremely simple and only address the stop signal used when running `docker stop`. `php-fpm` signal choices are somewhat peculiar (`SIGUSR2` for example) and if we want to "fix" them we would have to use a tool (e.g.: `dumb-init`). More info: - https://linux.die.net/man/8/php-fpm - https://docs.docker.com/engine/reference/builder/#stopsignal - https://github.com/Yelp/dumb-init - usabilla/php-docker-template#102
VenusPR
pushed a commit
to VenusPR/PHP_Project
that referenced
this pull request
Mar 12, 2023
The default signal used by docker to stop a container is SIGTERM and that signal is understood by PHP-FPM as immediate termination. This means that `php-fpm` won't wait for in-flight requests to finish before of stopping the workers and main process. This behaviour is quite undesired for production environments and should be avoided as much as possible. This implementation is meant to be extremely simple and only address the stop signal used when running `docker stop`. `php-fpm` signal choices are somewhat peculiar (`SIGUSR2` for example) and if we want to "fix" them we would have to use a tool (e.g.: `dumb-init`). More info: - https://linux.die.net/man/8/php-fpm - https://docs.docker.com/engine/reference/builder/#stopsignal - https://github.com/Yelp/dumb-init - usabilla/php-docker-template#102
principlesoftware-dev
added a commit
to principlesoftware-dev/PHP-branch
that referenced
this pull request
Sep 2, 2024
The default signal used by docker to stop a container is SIGTERM and that signal is understood by PHP-FPM as immediate termination. This means that `php-fpm` won't wait for in-flight requests to finish before of stopping the workers and main process. This behaviour is quite undesired for production environments and should be avoided as much as possible. This implementation is meant to be extremely simple and only address the stop signal used when running `docker stop`. `php-fpm` signal choices are somewhat peculiar (`SIGUSR2` for example) and if we want to "fix" them we would have to use a tool (e.g.: `dumb-init`). More info: - https://linux.die.net/man/8/php-fpm - https://docs.docker.com/engine/reference/builder/#stopsignal - https://github.com/Yelp/dumb-init - usabilla/php-docker-template#102
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usabilla PHP Docker Template
Reviewers: @fabiotc @rdohms @WyriHaximus @renatomefi @frankkoornstra @agustingomes @cvmiert
Type
Please specify the type of changes being proposed:
Changelog