fix: make function encrypt the error aswell, fix replay args mistake

Author: skoshx

e2e/replay.spec.ts

@@ -1,7 +1,7 @@
 import { expect, test } from "@playwright/test";
 import { REPLAY_NEXTJS_PORT, getBaseUrl, waitMs } from "./util";
 
-test.only('should replay front-end bug in nextjs example', async ({ page }) => {
+test('should replay front-end bug in nextjs example', async ({ page }) => {
 	// const capturesBefore = await fetchCaptures('sk_Y8dYLe5VoNJfDI_CPEqF8AqMTEwWAvTwBi7Ml-pN9bzWsgsP');
 	// Start from the index page (the baseURL is set via the webServer in the playwright.config.ts)
   await page.goto(getBaseUrl(REPLAY_NEXTJS_PORT));

playwright.config.ts

@@ -76,7 +76,7 @@ const config: PlaywrightTestConfig = {
 			env: {
 				PORT: REPLAY_NEXTJS_PORT.toString(),
         FLYTRAP_MODE: 'replay',
-        FLYTRAP_CAPTURE_ID: 'e75be9f6-ad3a-4c1d-9848-9dc50e74583e'
+        FLYTRAP_CAPTURE_ID: 'bbcffc6b-13dc-4be5-b458-6b6eb1597ba9',
 			},
 			timeout: 120 * 1000,
 			reuseExistingServer: !process.env.CI,

src/core/encryption.ts

@@ -251,21 +251,24 @@ export async function encryptCapture(
 	const linkedCalls = addLinksToCaptures(calls, { args, outputs })
 	const linkedFunctions = addLinksToCaptures(functions, { args, outputs })
 
-	const stringifyResult = Result.all(safeStringify(args), safeStringify(outputs))
+	const serializedError = serializeError(error)
+
+	const stringifyResult = Result.all(
+		safeStringify(args),
+		safeStringify(outputs),
+		error !== undefined ? safeStringify(serializedError) : Ok(undefined)
+	)
 
 	if (stringifyResult.err) {
 		return stringifyResult
 	}
 
-	const stringifiedErrorResult =
-		error === undefined ? Ok(undefined) : safeStringify(serializeError(error))
-
-	const [stringifiedArgs, stringifiedOutputs] = stringifyResult.val
+	const [stringifiedArgs, stringifiedOutputs, stringifiedError] = stringifyResult.val
 
 	const encryptionResult = Result.all(
 		await encrypt(publicKey, stringifiedArgs),
 		await encrypt(publicKey, stringifiedOutputs),
-		stringifiedErrorResult
+		stringifiedError !== undefined ? await encrypt(publicKey, stringifiedError) : Ok(undefined)
 	)
 
 	if (encryptionResult.err) {
@@ -274,8 +277,6 @@ export async function encryptCapture(
 
 	const [encryptedArgs, encryptedOutputs, encryptedError] = encryptionResult.val
 
-	const serializedError = serializeError(error)
-
 	return Ok({
 		capturedUserId,
 		projectId,

src/index.ts

@@ -126,14 +126,15 @@ export function uff<T extends AnyFunction>(func: T, id: string | null = null): T
 			}
 
 			// @ts-expect-error: because of NO-OP
-			const replayArgs = findLastInvocationById(id, currentLoadedCaptureResult.val)
+			const lastInvocation = findLastInvocationById(id, currentLoadedCaptureResult.val)
 
-			if (!replayArgs) {
+			if (!lastInvocation) {
 				const context = null
 				return func.apply(context ?? this, args)
 			}
 
 			// Merge replay args & real args
+			const replayArgs = lastInvocation.args
 			const mergedArgs = fillUnserializableFlytrapValues(replayArgs, args)
 			// @ts-expect-error for some reason `this as any` still gives error
 			return func.apply(context ?? this, mergedArgs)