Skip to content

fix(docker): ensure container exits instantly without hanging #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesbrink merged 1 commit into from
Apr 2, 2025
Merged

fix(docker): ensure container exits instantly without hanging #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,21 @@ RUN pip install --no-cache-dir -e .
RUN echo "Running pre-cache to populate cache data..." && \
python -m mcp_nixos --pre-cache

# Run the MCP server
CMD ["python", "-m", "mcp_nixos"]
# Set environment variables to ensure clean exit
ENV PYTHONUNBUFFERED=1
ENV MCP_NIXOS_CLEANUP_ORPHANS=true
# Set low timeout values for all operations
ENV MCP_NIXOS_SHUTDOWN_TIMEOUT=0.1
ENV MCP_NIXOS_STARTUP_TIMEOUT=1.0

# Use tini as init system to handle signals properly
RUN apt-get update && apt-get install -y tini && rm -rf /var/lib/apt/lists/*

# Use tini as entrypoint for proper signal forwarding and zombie reaping
ENTRYPOINT ["/usr/bin/tini", "--"]

# Run the MCP server through the run.py wrapper for better termination handling
CMD ["python", "-m", "mcp_nixos.run"]

# Add signal handler to ensure container exits cleanly
STOPSIGNAL SIGTERM
Loading