Skip to content

Remove unused initial value in Writer/File.ts writeImplementation #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simonmika merged 4 commits into from
Nov 6, 2025
Merged

Remove unused initial value in Writer/File.ts writeImplementation #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
42b53d6
Initial plan
Copilot Nov 6, 2025
c0e6f52
Fix unused initial value in Writer/File.ts writeImplementation
Copilot Nov 6, 2025
25427b4
Merge branch 'master-2' into copilot/sub-pr-10-again
simonmika Nov 6, 2025
8c9ee43
Fixed issues with fs.write signatures.
simonmika Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Writer/File.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@ export class File extends Writer {
return result
}
protected override async writeImplementation(buffer: Enumerator<string>): Promise<boolean> {
let result = true
const content = buffer.reduce((r, item) => r + item, "")
let result: boolean
const content = Buffer.from(buffer.reduce((r, item) => r + item, ""))
try {
const r = await fs.write(this.descriptor, content, null, "utf8")
const r = await fs.write(this.descriptor, content)
result = r.bytesWritten == content.length
} catch {
result = false
Expand Down
41 changes: 36 additions & 5 deletions fs.browser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,46 @@
import * as fs from "node:fs"

async function close(fd: number): Promise<void> {}
async function fsync(fd: number): Promise<void> {}
async function open(path: string, flags: string | number, mode?: string | number | undefined | null): Promise<number> {
return 0
}

async function write<TBuffer extends NodeJS.ArrayBufferView<ArrayBufferLike>>(
fd: number,
buffer?: TBuffer,
offset?: number,
length?: number,
position?: number | null
): Promise<{
bytesWritten: number
buffer: TBuffer
}>
async function write<TBuffer extends NodeJS.ArrayBufferView>(
fd: number,
buffer?: TBuffer,
options?: fs.WriteOptions
): Promise<{
bytesWritten: number
buffer: TBuffer
}>
async function write(
fd: number,
string: string,
position?: number | null,
encoding?: BufferEncoding | null
): Promise<{
bytesWritten: number
buffer: string
}>
async function write(
fd: number,
buffer: Buffer | string,
offset: number | undefined | null,
encoding: "utf8"
): Promise<{ bytesWritten: number }> {
return { bytesWritten: 0 }
buffer?: Buffer | string,
offset?: fs.WriteOptions | number | undefined | null,
length?: BufferEncoding | number | undefined | null,
position?: number | null
): Promise<{ bytesWritten: number; buffer: Buffer | string }> {
return { bytesWritten: 0, buffer: Buffer.alloc(0) }
}

function lstatSync(
Expand Down