Display number of modifications on viewer

[utkuakyuz]

Even though difference object is available and user can find the edited/removed/inserted line count, showing number of lines modified on viewer would be a good idea.

I am thinking of an optional prop to show/hide the stats of the memoized difference.

[SpringsTea]

Would be a cool option, you may have noticed I was doing that with my project.
Additionally, it would be nice if it could support json-diff-kits arrayDiffMethod compare-key option.

This option can display an entire object as a single add/removed. I use this to display how many objects in the array have been modified instead of how many lines.

[utkuakyuz]

Thanks for the feedback, I will be publishing new version including line count visuals.

The compare-key method is developed by myself for the exact reason as you mentioned, you can use it in VirtualDiffViewer like this:

 <VirtualDiffViewer
      {...props}
      differOptions={{ arrayDiffMethod: "compare-key", compareKey: "oid" }}
  />

All differ options available in json diff kit is also available on virtualDiffViewer, by using differOptions you can achieve it.

@SpringsTea

[SpringsTea]

Yes I understand that the differ options can be used. I mean that if this feature of counting change lines had different behavior when compare-key is used so that a changed object counts as one change, rather than the sum of it's line, that could be useful.

I'd understand if that's not very intuitive though.

[utkuakyuz]

Ah, I see what you mean now. That makes sense. I will experiment with this idea, maybe we can add an option to display how many objects were removed or edited separately when compare-key is used. Sorry for any confusion earlier.

Here’s what I’m thinking so far:

Add another prop to specify which array should be used to count differences in object numbers.

Add a callback that returns all arrays including their modified object counts (based on compare key).

Also, somewhat related, I have been considering a “likeliness-similarity score” feature. I am not entirely sure yet how it should work, but I am open to ideas. I will be creating a new issue for that separately.

[utkuakyuz]

Hey @SpringsTea , I published a new version 1.0.15.

See the new tab in demo page, implemented object count stats are shown properly in json diff arrays.

https://virtual-react-json-diff.netlify.app/

I think for both normal-lcs and other comparison stats and compare-key object count stats are now pretty well designed.

Only issue I noticed is #26 , I am not sure if you need it. In such a case we need to go through some examples and decide how kind of output we want. Please confirm if it works for you, if not, share you example JSON and we can discuss the way we count the objects.