Merge master into breaking #164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
clippy takes forever to build Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
163: Clippy r=Dylan-DPC a=kinggoesgaming  ~~This is declared a breaking change as per clippy requesting that `Hash` be derived, as @Dylan-DPC asked.~~
kinggoesgaming
requested review from
Dylan-DPC-zz,
KodrAus and
radix
as code owners
Dylan-DPC-zz
previously approved these changes
Mar 10, 2018
kinggoesgaming
changed the title
* [x] `extern crate`s * [x] already provided `mod`s Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
167: Use cfg-if to create logical feature gate implementations r=kinggoesgaming a=kinggoesgaming
<!--
As we are working towards a stable version of uuid, we require that you
open an issue, before submitting a pull request. If the pull request is
imcomplete, prepend the Title with WIP:
-->
**I'm submitting a ...**
- [ ] bug fix
- [ ] feature enhancement
- [ ] deprecation or removal
- [x] refactor
# Description
`uuid` now adds `cfg-if` as a dependency. With this, `#[cfg(..)]` implementations are easier to understand, as they can be handled in a more logical view because the macro allows us to `if` statements to make the checks more rustic at the source level
# Motivation
Understanding feature gate implementation becomes easier.
# Tests
The CI builds passing should be plenty.
# Related Issue(s)
#147
|
Seemingly WIP bot is broken again, if needed disable it for merge and enable again |
|
bors try |
tryBuild failed |
|
no idea why it failed... fmt locally shows no errors |
Dylan-DPC-zz
previously approved these changes
Mar 22, 2018
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
182: move test Uuid creation functions into new module r=Dylan-DPC a=kinggoesgaming **I'm submitting a ...** - [ ] bug fix - [ ] feature enhancement - [ ] deprecation or removal - [x] refactor # Description Refactor the `tests::new` and `tests::new2` functions into `test_util` module. # Motivation Part of the great refactor. Allows different tests in different modules access the test constructors for `Uuid` # Tests The tests are passing # Related Issue(s) #124
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
185: move slog implementation into its own module r=kinggoesgaming a=kinggoesgaming **I'm submitting a ...** - [ ] bug fix - [ ] feature enhancement - [ ] deprecation or removal - [x] refactor # Description The slog impl and tests are moved into `slog_support` module # Motivation As part of the refactor effort, feature gated implementations need to be moved into their own modules. # Tests Current provided tests are passing # Related Issue(s) #124
177: introduce the `uuid` prelude r=Dylan-DPC a=kinggoesgaming **I'm submitting a ...** - [ ] bug fix - [x] feature enhancement - [ ] deprecation or removal - [ ] refactor # Description Introduce the `prelude` module that provide the core types. # Motivation Provide the stable types that are important for users of `uuid` # Tests N/A # Related Issue(s) closes #166
|
I will open a separate PR that fixes the conflicts and such on a different branch |
|
Superseded by #186 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE Do not merge until before breaking actually gets breaking changes to merge commits count low
Description
Merge changes from master into breaking
Motivation
Routine commit update
Tests
N/A
Related Issue(s)
N/A