Skip to content

ls: fix symlink target coloring to match target file type #9006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

ls: fix symlink target coloring to match target file type #9006

wants to merge 9 commits into from

Conversation

@Agent-Hellboy
Copy link

@Agent-Hellboy Agent-Hellboy commented Oct 25, 2025 •
edited
Loading

fixes #8934

@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

sylvestre
sylvestre reviewed Oct 26, 2025
View reviewed changes
src/uu/ls/src/ls.rs Outdated
config: &Config,
command_line: bool,
) -> Self {
Self::new_with_dereference_override(p_buf, dir_entry, file_name, config, command_line, None)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the point of keeping this function ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, it was from an earlier patchset.

sylvestre
sylvestre reviewed Oct 26, 2025
View reviewed changes
src/uu/ls/src/ls.rs Outdated
if command_line {
if let Ok(md) = p_buf.metadata() {
md.is_dir()
let must_dereference =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe move this block into a new function to simplify the code

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 26, 2025

CodSpeed Performance Report

Merging #9006 will degrade performances by 3.53%

Comparing Agent-Hellboy:issue-8934 (dd307c9) with main (8f6e720)

Summary

❌ 1 regression
✅ 104 untouched
⏩ 74 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ du_human_balanced_tree[(5, 4, 10)] 10.1 ms 10.5 ms -3.53%

Footnotes

  1. 74 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sylvestre sylvestre sylvestre left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ls does not colorize symlink targets according to the target type

2 participants

@Agent-Hellboy @sylvestre