refactor: improve timestamp handling and test organization #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuankunzhang
force-pushed
the
improve-epoch
branch
from
061ce40 to
70055ea
Compare
cakebaker
reviewed
Aug 22, 2025
Comment on lines
+120
to
+133
| for (input, expected) in [ | ||
| ("@1234567890", ts(1234567890, 0)), // positive seconds, no nanoseconds | ||
| ("@ 1234567890", ts(1234567890, 0)), // space after '@', positive seconds, no nanoseconds | ||
| ("@-1234567890", ts(-1234567890, 0)), // negative seconds, no nanoseconds | ||
| ("@ -1234567890", ts(-1234567890, 0)), // space after '@', negative seconds, no nanoseconds | ||
| ("@ - 1234567890", ts(-1234567890, 0)), // space after '@' and after '-', negative seconds, no nanoseconds | ||
| ("@1234567890.12345", ts(1234567890, 123450000)), // positive seconds with nanoseconds, '.' as floating point | ||
| ("@1234567890,12345", ts(1234567890, 123450000)), // positive seconds with nanoseconds, ',' as floating point | ||
| ("@-1234567890.12345", ts(-1234567891, 876550000)), // negative seconds with nanoseconds, '.' as floating point | ||
| ("@1234567890.1234567890123", ts(1234567890, 123456789)), // nanoseconds with more than 9 digits, truncated | ||
| ] { | ||
| let mut s = input; | ||
| assert_eq!(parse(&mut s).unwrap(), expected, "{input}"); | ||
| } |
Collaborator
There was a problem hiding this comment.
Nice refactoring, it's now much easier to read with the boilerplate code gone.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #218 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.