feat: Implement fullscreen WebView for vshare with theme auto-adaptation #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

graycreate merged 3 commits into main from feature/vshare-fullscreen-theme

Oct 17, 2025

Member

graycreate commented Oct 16, 2025

Summary

Replace browser opening with native WebView for vshare page display
Implement automatic light/dark theme adaptation based on app's current mode
Provide fullscreen browsing experience with native controls

Changes

Added VshareWebActivity for fullscreen WebView display
Implemented theme detection and automatic URL parameter injection
Added JavaScript injection to ensure theme is properly applied
Integrated with existing vshare version checker system
Added progress bar for better loading feedback

Test Plan

Launch the app and open navigation drawer
Click on vshare menu item
Verify vshare page opens in fullscreen WebView (not browser)
Test light mode: switch app to light mode, verify vshare page displays with light theme
Test dark mode: switch app to dark mode, verify vshare page displays with dark theme
Test back navigation within the WebView
Verify badge disappears after viewing vshare

🤖 Generated with Claude Code


          feat: Implement fullscreen WebView for vshare with theme auto-adaptation

174d615

- Add VshareWebActivity for fullscreen display of vshare page
- Implement automatic light/dark theme adaptation based on app's current mode
- Replace browser opening with native WebView experience
- Add progress bar for loading indication
- Enable JavaScript and DOM storage for proper page functionality
- Handle back navigation within WebView

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Copilot AI review requested due to automatic review settings

October 16, 2025 16:16

Copilot AI reviewed

View reviewed changes

Copilot AI left a comment

Pull Request Overview

Implements an in‑app fullscreen WebView for the vshare feature with automatic light/dark theme adaptation instead of launching an external browser.

Adds VshareWebActivity with WebView setup, theme parameter injection, and JS-based theme enforcement.
Replaces external browser navigation with the new activity and updates manifest and layout.
Provides loading feedback via a horizontal ProgressBar.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.

File	Description
app/src/main/res/layout/activity_vshare_web.xml	New layout containing fullscreen WebView and a horizontal progress bar.
app/src/main/java/me/ghui/v2er/module/vshare/VshareWebActivity.java	New activity implementing fullscreen WebView, theme parameter + JS injection, navigation handling, and cleanup.
app/src/main/java/me/ghui/v2er/module/home/MainActivity.java	Replaces external browser launch with opening the new VshareWebActivity.
app/src/main/AndroidManifest.xml	Registers VshareWebActivity with a specific theme and configChanges.

app/src/main/java/me/ghui/v2er/module/vshare/VshareWebActivity.java Outdated

Comment on lines 105 to 107

+                              // Keep navigation within the WebView
+                              view.loadUrl(request.getUrl().toString());
+                              return true;

Copilot AI Oct 16, 2025

Returning true after calling view.loadUrl() forces manual handling of all navigations and can break POST requests or cause duplicate loads; you should return false and let the WebView handle standard navigation unless you have a specific interception case.

Suggested change

      
                            // Keep navigation within the WebView
          
                            view.loadUrl(request.getUrl().toString());
          
                            return true;
          
                            // Let the WebView handle the navigation
          
                            return false;

Copilot uses AI. Check for mistakes.

app/src/main/java/me/ghui/v2er/module/vshare/VshareWebActivity.java


		// Enable DOM storage
		settings.setDomStorageEnabled(true);

Copilot AI Oct 16, 2025

JavaScript + DOM storage are enabled for remote content without tightening other surfaces; consider explicitly disabling file and content access (settings.setAllowFileAccess(false); settings.setAllowContentAccess(false);) and enabling Safe Browsing (if API >= 26) to reduce attack surface.

Suggested change

      
                    // Disable file and content access for security
          
                    settings.setAllowFileAccess(false);
          
                    settings.setAllowContentAccess(false);
          
                    // Enable Safe Browsing if API >= 26
          
                    if (android.os.Build.VERSION.SDK_INT >= android.os.Build.VERSION_CODES.O) {
          
                        WebView.enableSafeBrowsing(mWebView.getContext());
          
                        settings.setSafeBrowsingEnabled(true);
          
                    }

Copilot uses AI. Check for mistakes.

app/src/main/java/me/ghui/v2er/module/vshare/VshareWebActivity.java Outdated

Comment on lines 40 to 49

+                  public static void open(Context context) {
+                      Intent intent = new Intent(context, VshareWebActivity.class);
+                      // Append theme parameter based on current app theme
+                      String url = VSHARE_BASE_URL;
+                      if (DarkModelUtils.isDarkMode()) {
+                          url += "?theme=dark";
+                      } else {
+                          url += "?theme=light";
+                      }
+                      intent.putExtra(KEY_URL, url);

Copilot AI Oct 16, 2025

The theme-specific URL is computed only once at launch; if the system switches between light/dark while the activity is alive, the existing intent extra is reused and may produce a mismatched initial rendering; recompute the URL in onCreate (based on current mode) or handle uiMode changes by overriding onConfigurationChanged and reloading with an updated parameter.

Copilot uses AI. Check for mistakes.

app/src/main/java/me/ghui/v2er/module/vshare/VshareWebActivity.java Outdated

+                          @Override
+                          public void onPageFinished(WebView view, String url) {
+                              super.onPageFinished(view, url);
+                              mProgressBar.setVisibility(View.GONE);

Copilot AI Oct 16, 2025

[nitpick] Progress bar visibility is controlled in both onPageFinished and onProgressChanged leading to duplicated logic; consolidate visibility handling (e.g., rely solely on WebChromeClient progress events) to reduce redundancy.

Suggested change

mProgressBar.setVisibility(View.GONE);

Copilot uses AI. Check for mistakes.

app/src/main/java/me/ghui/v2er/module/vshare/VshareWebActivity.java

Comment on lines +131 to +138

+                      mWebView.setWebChromeClient(new WebChromeClient() {
+                          @Override
+                          public void onProgressChanged(WebView view, int newProgress) {
+                              mProgressBar.setProgress(newProgress);
+                              if (newProgress == 100) {
+                                  mProgressBar.setVisibility(View.GONE);
+                              }
+                          }

Copilot AI Oct 16, 2025

[nitpick] Progress bar visibility is controlled in both onPageFinished and onProgressChanged leading to duplicated logic; consolidate visibility handling (e.g., rely solely on WebChromeClient progress events) to reduce redundancy.

Copilot uses AI. Check for mistakes.

app/src/main/java/me/ghui/v2er/module/vshare/VshareWebActivity.java Outdated

Comment on lines 156 to 157

		mWebView.clearCache(true);
		mWebView.loadUrl("about:blank");

Copilot AI Oct 16, 2025

[nitpick] Clearing cache with true on every destroy purges shared WebView cache and degrades subsequent load performance; unless there is a privacy requirement, remove clearCache(true) (or use clearCache(false)) and avoid unnecessary about:blank navigation.

Suggested change

      
                        mWebView.clearCache(true);
          
                        mWebView.loadUrl("about:blank");
          
                        mWebView.clearCache(false);

Copilot uses AI. Check for mistakes.

app/src/main/res/layout/activity_vshare_web.xml Outdated

+              <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
+                  android:layout_width="match_parent"
+                  android:layout_height="match_parent"
+                  android:background="?android:attr/windowBackground">

Copilot AI Oct 16, 2025

[nitpick] Using ?android:attr/windowBackground can bypass app-level theme customization (e.g., dynamic day/night palette); prefer ?attr/windowBackground to respect the app's themed attribute.

Suggested change

      
                android:background="?android:attr/windowBackground">
          
                android:background="?attr/windowBackground">

Copilot uses AI. Check for mistakes.

graycreate and others added 2 commits

October 17, 2025 00:21


          fix: Address Copilot review comments for VshareWebActivity

6c7dc8f

- Fix navigation handling: Return false in shouldOverrideUrlLoading to let WebView handle standard navigation
- Add security settings: Disable file/content access and enable Safe Browsing for API >= 26
- Fix theme switching: Compute URL in onCreate to handle live theme changes
- Remove redundant progress bar logic: Consolidate visibility handling in WebChromeClient
- Optimize cache handling: Use clearCache(false) to avoid purging shared cache
- Fix layout theming: Use app-themed attribute (page_bg_color) instead of android:attr

All issues identified by GitHub Copilot have been addressed.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>


          refactor: Simplify VshareWebActivity by reusing app theme system

f46417c

- Use NoneSlideBackableTheme instead of GalleryTheme for proper theme inheritance
- Remove manual SystemUI configuration code (now handled by theme)
- Add proper edge-to-edge display with LAYOUT_FULLSCREEN and LAYOUT_HIDE_NAVIGATION flags
- Fix layout background to use transparent color compatible with NoneSlideBackableTheme
- Set status bar icon color dynamically based on dark/light theme

Benefits:
- Reduces code duplication by leveraging existing theme infrastructure
- Automatic theme switching support (follows app's day/night mode)
- Consistent UI behavior with MainActivity
- Simpler and more maintainable code

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

graycreate merged commit f0d1619 into main

5 checks passed

graycreate deleted the feature/vshare-fullscreen-theme branch

October 17, 2025 03:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet