refactor: use BaseActivity's loading indicator for Vshare WebView #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced custom horizontal ProgressBar with BaseActivity's standard circular loading indicator to maintain UI consistency across the app. Changes: - Removed custom ProgressBar from XML layout - Removed @BindView for mProgressBar - Removed WebChromeClient (no longer needed for progress tracking) - Use showLoading() in onPageStarted() - Use hideLoading() in onPageFinished() This provides a cleaner, more consistent loading experience that matches other activities like TopicActivity, using the app's standard 55dp circular ProgressBar centered on screen. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Pull Request Overview
Refactors VshareWebActivity to rely on BaseActivity's built-in loading indicator instead of a custom horizontal ProgressBar for consistent UI.
- Removes the XML-defined horizontal ProgressBar and related binding/imports.
- Replaces explicit progress tracking via WebChromeClient with showLoading/hideLoading calls in WebViewClient.
- Simplifies loading logic by eliminating progress updates and relying on lifecycle callbacks.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/src/main/res/layout/activity_vshare_web.xml | Removes custom horizontal ProgressBar view to defer loading UI to BaseActivity. |
| app/src/main/java/me/ghui/v2er/module/vshare/VshareWebActivity.java | Eliminates ProgressBar handling and WebChromeClient, adds showLoading/hideLoading calls in page start/finish callbacks. |
Comment on lines
152
to
156
| @Override | ||
| public void onPageStarted(WebView view, String url, Bitmap favicon) { | ||
| super.onPageStarted(view, url, favicon); | ||
| mProgressBar.setVisibility(View.VISIBLE); | ||
| showLoading(); | ||
| } | ||
|
|
||
| @Override | ||
| public void onPageFinished(WebView view, String url) { | ||
| super.onPageFinished(view, url); | ||
| hideLoading(); |
There was a problem hiding this comment.
[nitpick] Loading indicator is only dismissed in onPageFinished; if a load fails (e.g., network error or SSL error) before completion, user may be left with a persistent spinner. Consider overriding onReceivedError and onReceivedHttpError to call hideLoading(), e.g.: override onReceivedError(...){ hideLoading(); } override onReceivedHttpError(...){ hideLoading(); } to ensure the indicator is cleared on failure paths.
Fixed the issue where WebView would briefly show white background before the page finishes loading in dark mode. Changes: 1. Set WebView background color to match theme before loading - Dark mode: #1a1a1a (dark gray) - Light mode: white 2. Enable FORCE_DARK on Android Q+ when in dark mode - Automatically applies dark styling to web content - Provides immediate dark appearance This ensures a consistent visual experience from the moment the WebView starts loading, eliminating the jarring white flash that previously occurred in dark mode. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Changed approach to completely eliminate white flash in dark mode: - Set WebView to INVISIBLE before loading - Apply theme via JavaScript when page finishes loading - Show WebView after 100ms delay to ensure JS executes - Hide loading indicator when WebView becomes visible This ensures users only see the WebView after the correct theme has been fully applied, completely eliminating the white flash that occurred during page load in dark mode. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…d increasing delay - Set WebView visibility to invisible in XML layout to prevent initial white flash - Increase delay from 100ms to 300ms to ensure theme JavaScript executes properly - This eliminates the white screen gap during page load in dark mode 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Address GitHub Copilot review feedback by adding error handling callbacks to dismiss the loading indicator when page load fails. Changes: - Add onReceivedError() override to hide loading on network/SSL errors - Add onReceivedHttpError() override to hide loading on HTTP errors - Both callbacks also hide the theme overlay to restore UI state This prevents the loading spinner from persisting indefinitely when WebView encounters errors during page load. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Apply navigation bar height as bottom margin to prevent content from being hidden under the navigation bar in fullscreen WebView. Changes: - Import Utils to access getNavigationBarHeight() - Update applyStatusBarMargin() to also apply bottom margin - Use Utils.getNavigationBarHeight() for bottom margin calculation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaced the custom horizontal ProgressBar with BaseActivity's standard circular loading indicator to maintain UI consistency across the app.
Changes
showLoading()/hideLoading()Benefits
Testing
🤖 Generated with Claude Code