fix: improve base64 decoding robustness #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added validation for all required environment variables - Implemented multiple base64 decoding methods as fallback - Added automatic whitespace/newline removal if needed - Added file verification to ensure API key was properly created - Better error messages for debugging This handles potential issues with: - Different base64 command flags (-d vs --decode) - Whitespace or newline characters in the secret - Empty or missing secrets
There was a problem hiding this comment.
Pull Request Overview
This PR improves the robustness of base64 decoding for App Store Connect API keys in the GitHub Actions release workflow. The changes add multiple fallback methods for base64 decoding, comprehensive error handling, and validation to ensure the API key file is properly created and configured.
- Enhanced base64 decoding with multiple fallback methods to handle different platform variations
- Added environment variable validation and file verification checks
- Improved error messages and debugging output for troubleshooting deployment issues
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| echo "APP_STORE_CONNECT_API_KEY_KEY_ID=$APP_STORE_CONNECT_KEY_ID" >> $GITHUB_ENV | ||
| echo "APP_STORE_CONNECT_API_KEY_ISSUER_ID=$APP_STORE_CONNECT_ISSUER_ID" >> $GITHUB_ENV | ||
| echo "APP_STORE_CONNECT_API_KEY_KEY=~/.appstoreconnect/private_keys/AuthKey_${APP_STORE_CONNECT_KEY_ID}.p8" >> $GITHUB_ENV | ||
| echo "APP_STORE_CONNECT_API_KEY_KEY=$KEY_PATH" >> $GITHUB_ENV |
There was a problem hiding this comment.
The KEY_PATH variable contains a tilde (~) which may not expand correctly when written to $GITHUB_ENV. Consider using $HOME instead of ~ or use an absolute path to ensure proper path resolution in subsequent workflow steps.
Code Coverage Report ❌Current coverage: 0% |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves base64 decoding with multiple fallback methods and better error handling