Skip to content

Fix: Configure automatic export compliance bypass for TestFlight #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 18, 2025
Merged

Fix: Configure automatic export compliance bypass for TestFlight #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
980f1ec
fix: Add export compliance key to resolve TestFlight Missing Complian…
graycreate Oct 18, 2025
6db8369
fix: Configure automatic export compliance bypass for TestFlight rele…
graycreate Oct 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions V2er/Info.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,5 +56,7 @@
</array>
<key>UIViewControllerBasedStatusBarAppearance</key>
<true/>
<key>ITSAppUsesNonExemptEncryption</key>
<false/>
</dict>
</plist>
19 changes: 16 additions & 3 deletions fastlane/Fastfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,11 @@ platform :ios do
provisioningProfiles: {
"v2er.app" => "match AppStore v2er.app"
},
teamID: ENV["TEAM_ID"]
teamID: ENV["TEAM_ID"],
ITSAppUsesNonExemptEncryption: false, # Add export compliance to IPA
Copy link

Copilot AI Oct 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ITSAppUsesNonExemptEncryption is an Info.plist key and not a valid export option for the export_options hash; it will be ignored here. Remove it from export_options (line 46) and rely on the Info.plist addition instead.

Suggested change
ITSAppUsesNonExemptEncryption: false, # Add export compliance to IPA

Copilot uses AI. Check for mistakes.
uploadBitcode: false,
compileBitcode: false,
uploadSymbols: true
},
export_team_id: ENV["TEAM_ID"],
xcargs: "-allowProvisioningUpdates CODE_SIGN_STYLE=Manual",
Expand Down Expand Up @@ -85,7 +89,9 @@ platform :ios do
wait_for_uploaded_build: true,
groups: ["Github Actions Internal"], # Auto-distribute to Github Actions Internal group
Copy link

Copilot AI Oct 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct capitalization of 'Github' to 'GitHub' to match the proper brand name.

Copilot uses AI. Check for mistakes.
notify_external_testers: false, # No external notifications
uses_non_exempt_encryption: false # Mark as no encryption to skip export compliance review
uses_non_exempt_encryption: false, # Mark as no encryption to skip export compliance review
Copy link

Copilot AI Oct 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment says 'no encryption' but the app uses standard TLS (exempt encryption). Update the comment to 'Only exempt (standard TLS) encryption used' for accuracy.

Suggested change
uses_non_exempt_encryption: false, # Mark as no encryption to skip export compliance review
uses_non_exempt_encryption: false, # Only exempt (standard TLS) encryption used

Copilot uses AI. Check for mistakes.
export_compliance_uses_encryption: false, # Explicitly state no encryption
export_compliance_is_exempt: true # Exempt from export compliance
Comment on lines +92 to +94
Copy link

Copilot AI Oct 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Export compliance flags are duplicated across lanes; centralize them (e.g., helper method or shared hash) to reduce drift and simplify updates. Additionally, consider only the minimal necessary keys (uses_non_exempt_encryption plus, if applicable, export_compliance_is_exempt) to avoid noise.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Oct 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Setting export_compliance_is_exempt true while also declaring uses_non_exempt_encryption false and export_compliance_uses_encryption false is redundant; exemption only matters if encryption is used but exempt. Remove export_compliance_is_exempt when uses_encryption is false to prevent contradictory metadata.

Suggested change
export_compliance_is_exempt: true # Exempt from export compliance

Copilot uses AI. Check for mistakes.
)

UI.success("✅ Successfully distributed build to internal testers (Github Actions Internal)!")
Copy link

Copilot AI Oct 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct capitalization of 'Github' to 'GitHub' to match the proper brand name.

Copilot uses AI. Check for mistakes.
Expand Down Expand Up @@ -180,7 +186,14 @@ platform :ios do
distribute_external: is_public_beta, # Internal testing by default, external for public beta
distribute_only: false, # Upload and distribute in one action
changelog: changelog_content, # Use changelog from CHANGELOG.md
uses_non_exempt_encryption: false # Mark as no encryption to skip export compliance review
uses_non_exempt_encryption: false, # Mark as no encryption to skip export compliance review
Copy link

Copilot AI Oct 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Setting export_compliance_is_exempt true while also declaring uses_non_exempt_encryption false and export_compliance_uses_encryption false is redundant; exemption only matters if encryption is used but exempt. Remove export_compliance_is_exempt when uses_encryption is false to prevent contradictory metadata.

Copilot uses AI. Check for mistakes.
export_compliance_uses_encryption: false, # Explicitly state no encryption for export compliance
export_compliance_platform: 'ios', # Specify platform for export compliance
export_compliance_compliance_required: false, # No additional compliance documentation required
export_compliance_app_type: nil, # Not applicable since we don't use encryption
Copy link

Copilot AI Oct 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Passing export_compliance_app_type: nil adds an unnecessary key; omit the parameter entirely when not applicable to produce cleaner metadata.

Suggested change
export_compliance_app_type: nil, # Not applicable since we don't use encryption

Copilot uses AI. Check for mistakes.
export_compliance_encryption_updated: false, # No encryption changes
export_compliance_contains_third_party_cryptography: false, # No third-party cryptography
export_compliance_is_exempt: true # Exempt from export compliance
Comment on lines +189 to +196
Copy link

Copilot AI Oct 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Export compliance flags are duplicated across lanes; centralize them (e.g., helper method or shared hash) to reduce drift and simplify updates. Additionally, consider only the minimal necessary keys (uses_non_exempt_encryption plus, if applicable, export_compliance_is_exempt) to avoid noise.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Oct 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Setting export_compliance_is_exempt true while also declaring uses_non_exempt_encryption false and export_compliance_uses_encryption false is redundant; exemption only matters if encryption is used but exempt. Remove export_compliance_is_exempt when uses_encryption is false to prevent contradictory metadata.

Suggested change
export_compliance_is_exempt: true # Exempt from export compliance

Copilot uses AI. Check for mistakes.
}

# Add channel-specific distribution parameters
Expand Down
Loading