Skip to content

Conversation

@umlaeute
Copy link
Collaborator

Inspired by #380, this PR creates a badge from the performed tests.

It's currently viewable on the wiki, and looks like this:

v4l2loopback builds with multiple kernels

@umlaeute umlaeute added the topic:documentation things regrading missing/wrong/outdated documentation label Apr 11, 2025
@umlaeute umlaeute self-assigned this Apr 11, 2025
@umlaeute umlaeute requested a review from Copilot April 11, 2025 13:40
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (2)

.github/workflows/kmod-compatibility-checks.yml:106

  • Failure log entries omit the OS version, unlike the success and skip entries. Consider including the OS version for consistent output.
echo "${osname} ${osrelease} ${k} failure" >> "${statefile}"

.github/workflows/kmod-compatibility-checks.yml:136

  • The use of '>' overwrites the badge.svg file created on line 135, causing loss of the initial SVG header. Use '>>' to append instead.
echo "<style>.success {fill:#4C1} ..." | sed -e "s|@height@|$((numtests * 22))|g" > badge.svg

run: |
find */ -type f -name "buildstate.txt" -exec grep -h . {} + | sort -u > allstates.txt
numtests=$(grep -c . allstates.txt)
echo '<?xml version="1.0" encoding="UTF-8"?> <svg xmlns="http://www.w3.org/2000/svg" width="323" height="@height@">" > badge.svg
Copy link

Copilot AI Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an extraneous double quote at the end of the SVG header, which might lead to rendering issues. Please verify and correct the intended SVG header format.

Suggested change
echo '<?xml version="1.0" encoding="UTF-8"?> <svg xmlns="http://www.w3.org/2000/svg" width="323" height="@height@">" > badge.svg
echo '<?xml version="1.0" encoding="UTF-8"?> <svg xmlns="http://www.w3.org/2000/svg" width="323" height="@height@"> > badge.svg

Copilot uses AI. Check for mistakes.
@umlaeute umlaeute changed the title Create a badge with for all kernels tested in the CI Create a badge with all kernels tested in the CI Apr 11, 2025
IOhannes m zmölnig added 3 commits April 11, 2025 18:43
so it works for the overly long ubuntu kernels
(like "5.19.0-1014-nvidia-lowlatency")

also fix the setting of the height...
@umlaeute umlaeute merged commit 26df139 into main Apr 11, 2025
13 checks passed
@umlaeute umlaeute deleted the badges branch April 11, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic:documentation things regrading missing/wrong/outdated documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants