-
Notifications
You must be signed in to change notification settings - Fork 578
Create a badge with all kernels tested in the CI #627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
.github/workflows/kmod-compatibility-checks.yml:106
- Failure log entries omit the OS version, unlike the success and skip entries. Consider including the OS version for consistent output.
echo "${osname} ${osrelease} ${k} failure" >> "${statefile}"
.github/workflows/kmod-compatibility-checks.yml:136
- The use of '>' overwrites the badge.svg file created on line 135, causing loss of the initial SVG header. Use '>>' to append instead.
echo "<style>.success {fill:#4C1} ..." | sed -e "s|@height@|$((numtests * 22))|g" > badge.svg
| run: | | ||
| find */ -type f -name "buildstate.txt" -exec grep -h . {} + | sort -u > allstates.txt | ||
| numtests=$(grep -c . allstates.txt) | ||
| echo '<?xml version="1.0" encoding="UTF-8"?> <svg xmlns="http://www.w3.org/2000/svg" width="323" height="@height@">" > badge.svg |
Copilot
AI
Apr 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an extraneous double quote at the end of the SVG header, which might lead to rendering issues. Please verify and correct the intended SVG header format.
| echo '<?xml version="1.0" encoding="UTF-8"?> <svg xmlns="http://www.w3.org/2000/svg" width="323" height="@height@">" > badge.svg | |
| echo '<?xml version="1.0" encoding="UTF-8"?> <svg xmlns="http://www.w3.org/2000/svg" width="323" height="@height@"> > badge.svg |
so it works for the overly long ubuntu kernels (like "5.19.0-1014-nvidia-lowlatency") also fix the setting of the height...
Inspired by #380, this PR creates a badge from the performed tests.
It's currently viewable on the wiki, and looks like this: