Skip to content

Conversation

@aleksandar-ivic
Copy link
Contributor

Problem

--minor flag didn't reset patch version. --major flag didn't reset minor and patch

Solution

--minor flag resets patch to zero
--major flag resets minor and patch to zero

Changelog

Fix increase version for --minor and --major flags by properly resetting lower version numbers to zero

Copilot AI review requested due to automatic review settings February 28, 2025 13:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR fixes the version increase logic by ensuring that lower version numbers are reset when using the --minor and --major flags.

  • increment_major now resets both minor and patch to 0
  • increment_minor now resets the patch to 0

Reviewed Changes

File Description
deploy/increase_version.py Updated increment_major and increment_minor to reset lower version numbers

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@umbertoDifa umbertoDifa merged commit b37f2fb into master Feb 28, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants