Fix type annotation #1056
Merged
Fix type annotation #1056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes type annotation issues that prevent Darwin v1.3.0 from running on Python 3.9 by replacing incompatible union syntax with Optional.
- Changed type annotation for the url property in the ReportJob class
- Ensures compatibility with Python 3.9 by using Optional[str]
Comments suppressed due to low confidence (1)
darwin/datatypes.py:1576
- Ensure that 'Optional' is imported from the 'typing' module if it's not already imported elsewhere in the file.
url: Optional[str]
umbertoDifa
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Type annotaitons like
str | Noneare not supported for python 3.9. Darwin v1.3.0 can't be usedSolution
Change annotation to
Optional[str]Changelog
Fix type annotaiton, use
Optional