[DAR-7134][Internal] e2e test for nifti multi-segment conversion #1087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds e2e test data and test case for NIfTI multi-segment conversion functionality. This follows up on a previous logic change (PR #1086) to provide comprehensive testing of the NIfTI conversion feature with multi-segment annotations.
- Adds test data files for three different DICOM orientations (sagittal, coronal, axial) with multi-segment mask annotations
- Integrates the new test case into the existing CLI convert test suite
- Provides test coverage for NIfTI multi-segment conversion scenarios
Reviewed Changes
Copilot reviewed 4 out of 13 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sagittal_LPI_pixdim_0.1_0.2_0.5.json | Test data for sagittal orientation DICOM with two mask segments |
| coronal_LAS_pixdim_0.1_0.2_0.5.json | Test data for coronal orientation DICOM with two mask segments |
| axial_RPI_pixdim_1.0_1.0_1.0.json | Test data for axial orientation DICOM with two mask segments |
| e2e_tests/cli/test_convert.py | Adds new test case for nifti-multi-segment conversion |
umbertoDifa
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy of the original PR #1083 by @Jo-Byr, to run our CI
Problem
See #1086 for the logic change. A full cycle e2e test needs to be added in a separate PR, after the logic change is rolled out to busybee, becuase the e2e depends on the server-side version of darwin-py used for export in nifti format.
Solution
We add the e2e tests in a separate PR.
NOTE: Testing full cycle in darwin annotation format does not quite cover the logic change - we need a test in nifti annotation format. However:
Changelog
e2e test for nifti multi-segment conversion