[V7-3952] Support multi array coco segmentation import #511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V7-3952 Support multi array coco segmentation imports
Currently we are silently dropping any extra list of points in coco |
owencjones
approved these changes
Jan 11, 2023
Contributor
owencjones
left a comment
owencjones
left a comment
There was a problem hiding this comment.
LGTM. Bit worried that it didn't break any unit tests, so I'll add a ticket to write them.
Contributor
|
Closing in favour of #989 which accomplishes the same goal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In coco a segmentation can have more than polygon (in those cases it's an array of arrays of points), right now we are only importing the first element. This PR changes the logic to import all of them.