[ANN-2419][internal] Make mask annotation's sparse_rle field optional #659
+3
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ANN-2419 Fix mask validation in darwin-py
We made |
AndriiKlymchuk
commented
Sep 13, 2023
| def _parse_darwin_mask_annotation(annotation: dict) -> Optional[dt.Annotation]: | ||
| if not annotation.get("mask"): | ||
| raise ValueError("Mask annotation must have a 'mask' field") | ||
|
|
Contributor
Author
There was a problem hiding this comment.
No need in this condition as it checked one more time below.
AndriiKlymchuk
commented
Sep 13, 2023
darwin/utils/utils.py
Outdated
| slot_names: Optional[List[str]] = parse_slot_names(annotation) | ||
|
|
||
| if not id or not name or not mask or not slot_names: | ||
| if not id or not name or mask == None or not slot_names: |
Contributor
Author
There was a problem hiding this comment.
mask field could contain empty object which is valid, but is falsy value, therefore we should explicitly check None value.
owencjones
suggested changes
Sep 13, 2023
Contributor
owencjones
left a comment
owencjones
left a comment
There was a problem hiding this comment.
Just a couple of minor changes requested, to do with code convention to avoid bugs in identity Vs equality comparators.
owencjones
approved these changes
Sep 13, 2023
Contributor
owencjones
left a comment
owencjones
left a comment
There was a problem hiding this comment.
All looks good now. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We made sparse_rle field non required and don't save it in the db anymore. Validation in darwin-py must reflect it.
Solution
Adjust import validation
Changelog
Make
sparse_rlefield of mask annotations optional during import