[AI-1245] added albumentations transform test #672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AI-1245 Add transformation albumentations test in darwin-py
Add transformation albumentations test in darwin-py |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
owencjones
suggested changes
Oct 1, 2023
Contributor
owencjones
left a comment
owencjones
left a comment
There was a problem hiding this comment.
One change requested, also reach out on slack to sort the issue with albumentations
owencjones
approved these changes
Oct 13, 2023
Contributor
owencjones
left a comment
owencjones
left a comment
There was a problem hiding this comment.
Looks good, good test coverage with happy and sad paths
owencjones
approved these changes
Oct 16, 2023
Contributor
owencjones
left a comment
owencjones
left a comment
There was a problem hiding this comment.
Yeah, all looking good. Ready for QA.
| "python.formatting.blackPath": "black", | ||
| "python.formatting.provider": "none", | ||
| "python.formatting.provider": "black", | ||
| "python.formatting.blackArgs": [ |
Contributor
There was a problem hiding this comment.
Removing these lines below on here will mean that formatOnSave starts working better
ChristofferEdlund
deleted the
ai-1245-add-transformation-albumentations-test-in-darwin-py
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
No pytests for the new albumentations transform in darwin-py transforms
Solution
Added a pytest
Changelog