[IO-1445][external] Changes to LocalDataset() & get_annotations() to account for local releases pulled with folders #678
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… pulled with folders
Problem
When local releases are pulled with folders, construction of LocalDataset objects & the get_annotations() function fail due to a mismatch between annotation file names and item names. A more in-depth breakdown is available in the IO-1445 Linear ticket
Solution
Instead of comparing the file names of the JSON with items, parse each JSON file to guarantee the correct local path for each item is checked against. This has the side effect of introducing significantly higher runtimes when parsing large JSON files. Therefore, make LocalDataset & get_annotations() use a streaming library to prevent this.
Changelog