tweaks to older code checks #688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owencjones
reviewed
Oct 17, 2023
| file_extension: str = argv[0] | ||
| files_in: List[str] = argv[1:] | ||
|
|
||
| if file_extension.startswith("."): |
Contributor
There was a problem hiding this comment.
This file is used by other steps as well as typechecking, so will affect those too - is that deliberate?
Contributor
Author
There was a problem hiding this comment.
Yeah this is meant to stop it forcing people to rewrite a whole file as per ruff/black guidelines for code in the older modules, as our discussion on thursday/friday.
Nathanjp91
commented
Oct 17, 2023
|
|
||
| [tool.ruff.per-file-ignores] | ||
| "__init__.py" = ["E402", "F401"] | ||
| "path/to/file.py" = ["E402"] |
Contributor
Author
There was a problem hiding this comment.
What was this even doing here?
owencjones
approved these changes
Oct 17, 2023
Contributor
owencjones
left a comment
owencjones
left a comment
There was a problem hiding this comment.
Approved after discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
typechecking should ignore older code for now until better system can be merged
Solution
typechecking no longer enforces on older code
Changelog
typechecking no longer enforces on older code