[PY-605][external]Added support for folder structures when importing CSV video tags #724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PY-605 Bug: csv_tags_video imports assume a flat folder structure
Summary (describe an issue): csv_tags_video imports do not work for items in dataset folders Steps to reproduce (WIP) Expected Behaviour csv_tags_video imports should work with files in folder structures |
owencjones
approved these changes
Nov 17, 2023
Contributor
owencjones
left a comment
owencjones
left a comment
There was a problem hiding this comment.
Yep, seems fine to me. I don't know if this is heavily used, but useful change nonetheless.
Bit of a worry that it didn't break a test, so we could ticket introducing one it would break.
Contributor
Author
Good idea, I've ticketed the test in PY-606 |
saurbhc
reviewed
Nov 28, 2023
Co-authored-by: saurbhc <sc@saurabhchopra.co.uk>
|
QA passed, pair tested with John, imports to files within folders are now working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, CSV video tag imports assume items are in a flat folder structure, meaning the importer ignores files in folder structures.
Solution
Added logic to pull out and consider the remote path when importing
Changelog
Added support for folder structures when importing CSV video tags