[PY-619] metadata.json parser utilities
#738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nathanjp91
reviewed
Dec 6, 2023
Nathanjp91
reviewed
Dec 6, 2023
Nathanjp91
reviewed
Dec 6, 2023
darwin/path_utils.py
Outdated
| with open(path) as f: | ||
| manifest = json.load(f) | ||
|
|
||
| return manifest |
Contributor
There was a problem hiding this comment.
can we parse_manifest(manifest) here as well so we're returning the list[property] rather than raw dict
Member
Author
There was a problem hiding this comment.
the reason why I put both parsing functions in different files:
parse_manifestin path_utils.pyparse_propertiesin datatypes.py
is because it needs thePropertyclass to be imported from datatypes.py file - and when imported in path_utils.py, it creates a cyclic dependency on both files.
Other solution would be to move the Property class to path_utils.py? Thoughts?
Nathanjp91
suggested changes
Dec 6, 2023
Contributor
Nathanjp91
left a comment
Nathanjp91
left a comment
There was a problem hiding this comment.
Some things to change.
saurbhc
changed the title
manifest.json parser utilitiesmetadata.json parser utilities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Feature request: need utility functions for parsing
metadata.jsonto import Properties when importing Annotations.Solution
Parse
metadata.jsonto create list of newly introduced Property class.Changelog
Parsing
metadata.jsonfor Properties Import