[DAR-2606][External] Strip leading & trailing whitespaces from class names when reading Darwin JSON annotations #866
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It's not possible to create annotation class names with leading or trailing whitespaces in the Darwin platform. However, when importing annotation class names with leading or trailing whitespaces in Darwin JSON 2.0, darwin-py doesn't strip these whitespaces away. This means that when comparing the list of local classes against the list of remote classes, darwin-py treats these classes as new and tries unsuccessfully to create them. The following error is then thrown:
darwin.exceptions.ValidationError: {'errors': {'name': ['Class of type tag with name: WEED:BROADLEAF already exists.']}}Solution
This PR strips the leading and trailing whitespaces from class names when importing Darwin JSON 2.0
Changelog
Strip leading and trailing whitespace characters from annotation class names upon import of Darwin JSON 2.0 annotations, more closely mirroring the frontend behaviour of annotation class names