[DAR-4931][External] Fixed regression affecting converting complex polygons to coco #969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriiKlymchuk
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In this section of PLA-585, we removed the coco exporter's ability to export complex polygons. This was done by mistake as part of removing V1 code
Solution
Re-add the logic for converting complex polygons. In the COCO format:
iscrowd=0) are represented as series of(x, y)pointsiscrowd=1) are represented with RLEAlso updated existing unit & E2E tests for converting to COCO to include complex polygons
Changelog
Fixed regression affecting conversion of complex polygons to the COCO format