[DAR-4813][External] Allow upload of volumetric DICOM series from folders of DICOM slices #974
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We discovered that DICOM slices uploaded as series via darwin-py would result in items that could not be viewed in MPR, and some would outright fail to process - This is despite the same files being uploadable via the UI as ZIP archives with the
.dcmextensionThis comes down to a difference in the way that darwin-py was uploading data vs. what happens happens when you upload a
.dcmZIP archive through the UI. Currently, darwin-py sends a registration payload to/register_uploadcontaining as many objects are there are slices to be uploaded. This causes backend to assume the item is a multi-slotted item, in which case we cannot display volumes. Therefore backend setsis_volume=False, which disables MPRThe reason backend makes this assumption is that it currently doesn't have a way to know for certain if every item in the payload is part of the same slot at the point where this logic is present
Solution
This PR changes the way darwin-py uploads DICOM series. Specifically:
.dcmignore_dicom_layoutflag when uploading DICOM series to more closely mirror the UI-upload experience"0"as this is required for MPR to worklayouttoNoneas layout is not required for single-slotted itemsChangelog
Allowed upload of volumetric DICOM series from folders of slices via darwin-py