Skip to content

Conversation

@JBWilkie
Copy link
Contributor

Problem

This validation logic introduced in DAR-3846 only covers a very rare edge case, and makes very expensive API calls for every push operation

Solution

We remove this validation and may re-introduce this validation on the backend in the future

Changelog

Removed expensive pre-push validation from darwin-py that provided a negligible benefit

@linear
Copy link

linear bot commented Dec 18, 2024

@JBWilkie JBWilkie merged commit e053c42 into master Dec 18, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants