Skip to content

Conversation

@jhnns
Copy link
Contributor

@jhnns jhnns commented Oct 24, 2017

Makes contributing easier :)

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@jhnns
Copy link
Contributor Author

jhnns commented Oct 24, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@bmeurer bmeurer merged commit 3f41e0b into v8:master Oct 25, 2017
@bmeurer
Copy link
Member

bmeurer commented Oct 25, 2017

Thanks!

@jhnns jhnns deleted the add/editor-config branch October 25, 2017 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants