feat: moving demo app to spring boot and adding docker support #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x resource not found issue # Conflicts: # Dockerfile
Copied DemoView and SourceContentResolver, from vaadin demo helpers, and modified them to work with spring. Added to the build so that java files are also copied over and not just class files so that we can read the java files at runtime.
There was a problem hiding this comment.
Pull Request Overview
This pull request migrates the demo application to Spring Boot to produce an executable JAR and adds Docker support via a multi-stage build.
- Switches demo packaging from WAR to Spring Boot JAR and introduces
Applicationmain class - Updates Maven POMs for Spring Boot parent, dependencies, build plugins, and includes Java resources for source parsing
- Adds a Dockerfile with a multi-stage build to produce a minimal container image
Reviewed Changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| vcf-toolbar-layout-flow-demo/pom.xml | Switched packaging to jar, added Spring Boot parent, updated dependencies, build plugins, and profiles |
| Dockerfile | Introduced multi-stage Docker build and runtime ENTRYPOINT |
| vcf-toolbar-layout-flow-demo/src/main/resources/application.properties | Configured server port and Vaadin/Spring properties |
| vcf-toolbar-layout-flow-demo/src/main/java/org/vaadin/addons/componentfactory/demo/Application.java | Added Spring Boot application launcher |
| vcf-toolbar-layout-flow/pom.xml | Replaced hard-coded Vaadin test dependency version with the ${vaadin.version} property |
| vcf-toolbar-layout-flow-demo/src/main/java/org/vaadin/addons/componentfactory/demo/helpers/SpringSourceContentResolver.java | New helper to load source examples under Spring Boot |
| vcf-toolbar-layout-flow-demo/src/main/java/org/vaadin/addons/componentfactory/demo/helpers/AbstractDemoView.java | Refactored demo base class to use the new resolver |
| vcf-toolbar-layout-flow-demo/src/main/java/org/vaadin/addons/componentfactory/demo/ToolbarLayoutDemoView.java | Updated demo view to extend AbstractDemoView, added headline and removed reliance on the old DemoView |
Comments suppressed due to low confidence (2)
vcf-toolbar-layout-flow-demo/src/main/resources/application.properties:10
- Remove the extra '=' in the property assignment so it reads
vaadin.allowed-packages=com.vaadin,org.vaadin,dev.hilla,to ensure the property is recognized.
vaadin.allowed-packages= = com.vaadin,org.vaadin,dev.hilla,
vcf-toolbar-layout-flow-demo/pom.xml:144
- The
productionprofile no longer sets<vaadin.productionMode>true</vaadin.productionMode>or includes theflow-server-production-modedependency, which are required for a proper Vaadin production build. Consider restoring those settings.
<id>production</id>
...t-flow-demo/src/main/java/org/vaadin/addons/componentfactory/demo/ToolbarLayoutDemoView.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving to spring boot allows us to create an executable jar with embedded server. This way we can build the jar and copy it to the docker image, keeping it small.