-
Notifications
You must be signed in to change notification settings - Fork 214
docs: update overlay components styling docs for V25 #4541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AI Language ReviewIn the updated "Popover" documentation file:
Other than these points, the document is well-structured and provides comprehensive information about the component's functionality and styling. |
cb5445f to
60f533d
Compare
a867872 to
8af6bc5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still several references to overlay elements in the component articles:
Date picker:
Today button:: `vaadin-date-picker-overlay+++<wbr>+++** [slot="today-button"]**`
Cancel button:: `vaadin-date-picker-overlay+++<wbr>+++** [slot="cancel-button"]**`Menu bar:
Separator element `vaadin-menu-bar-overlay **[role="separator"]**`MSBC:
Overlay element:: `vaadin-multi-select-combo-box-overlay`
Overlay background:: `vaadin-multi-select-combo-box-overlay+++<wbr>+++**::part(overlay)**`
Overlay content wrapper:: `vaadin-multi-select-combo-box-overlay+++<wbr>+++**::part(content)**`
Overlay in loading state:: `vaadin-multi-select-combo-box-overlay+++<wbr>+++**[loading]**`
Overlay loading indicator:: `vaadin-multi-select-combo-box-overlay+++<wbr>+++**::part(loader)**`Popover:
The maximum width of popovers is limited to the width of the viewport, minus a small margin that can be customized with CSS by overriding the `inset` property of the `vaadin-popover-overlay` element.Root element:: `vaadin-popover-overlay`
=== States
Non-modal:: `vaadin-popover-overlay+++<wbr>+++**[modeless]**`
=== Parts
Modality curtain (backdrop):: `vaadin-popover-overlay+++<wbr>+++**::part(backdrop)**`
Popover surface:: `vaadin-popover-overlay+++<wbr>+++**::part(overlay)**`
Content wrapper:: `vaadin-popover-overlay+++<wbr>+++**::part(content)**`
Arrow element:: `vaadin-popover-overlay+++<wbr>+++**::part(arrow)**`Tooltip:
Root element:: `vaadin-tooltip-overlay`
=== Parts
Tooltip surface:: `vaadin-tooltip-overlay+++<wbr>+++**::part(overlay)**`
Content wrapper:: `vaadin-tooltip-overlay+++<wbr>+++**::part(content)**`There are also some in the general component styling docs which needs an update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed. Also updated general styling docs to not mention date-picker overlay.
8ef43f3 to
85dca70
Compare
| Contents that exceed the width of the popover will scroll. | ||
|
|
||
| The maximum width of popovers is limited to the width of the viewport, minus a small margin that can be customized with CSS by overriding the `inset` property of the `vaadin-popover-overlay` element. | ||
| The maximum width of popovers is limited to the width of the viewport, minus a small margin that can be customized by the theme. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might add custom CSS property for this and then list it when adding base styles properties docs.
d12ce66 to
3ddf086
Compare
Updated Styling docs for overlay based components to use new part names.