Skip to content

Conversation

@HerbertsVaadin
Copy link
Contributor

Solves #4661

  • Replaced ComponentEffect.format with its equivalent, since the format method has been removed.
  • Verified all other the examples still work
  • Added link to server push documentation where it was mentioned.

Added link to server push docummentation where it was mentioned.
@HerbertsVaadin HerbertsVaadin added the target/v24 cherry pick to v24 branch label Oct 20, 2025
@github-actions
Copy link

github-actions bot commented Oct 20, 2025

AI Language Review

In the file "Manage UI State With Signals":

  1. The section "Simple Counter Example" provides two code snippets that demonstrate similar functionality. The updated example uses the ComponentEffect.effect without the intermediate helper function ComponentEffect.format. This change improves clarity by directly showing the effect implementation.

  2. There's a reference to enabling push in the "Text Field Example" section, which uses a special syntax (<<{articles}/flow/advanced/server-push#push.configuration.enabling,enable push>>). This change makes the instruction clear and actionable.

Overall, the changes enhance the existing examples and documentation by clarifying implementation details, such as showing direct code instead of abstracted helper functions. No issues require improvement in the modified sections.

@mshabarov mshabarov self-requested a review October 21, 2025 10:33
@CLAassistant
Copy link

CLAassistant commented Oct 23, 2025

CLA assistant check
All committers have signed the CLA.

@mshabarov
Copy link
Contributor

@HerbertsVaadin please sign the new CLA.

@HerbertsVaadin
Copy link
Contributor Author

@mshabarov thanks, done.
What's the process from this point usually, once approved? Am I expected to merge myself, or await someone else to do it?

@mshabarov mshabarov merged commit 32690a9 into main Oct 23, 2025
4 checks passed
@mshabarov mshabarov deleted the chore/fix-signal-format-usage branch October 23, 2025 11:55
vaadin-bot pushed a commit that referenced this pull request Oct 23, 2025
Added link to server push docummentation where it was mentioned.

Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
mshabarov added a commit that referenced this pull request Oct 24, 2025
Added link to server push docummentation where it was mentioned.

Co-authored-by: Herberts <80950643+HerbertsVaadin@users.noreply.github.com>
Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-picked-v24 target/v24 cherry pick to v24 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants