fix: Change client selectAll update to use LinkedHashSet (CP: 25.1) (#9169) (#9175) (CP: 24.10) (#9177)

This PR cherry-picks changes from the original PR #9175 to branch 24.10.

---

> This PR cherry-picks changes from the original PR #9169 to branch
25.1.
> 
> ---
> 
> > Fixes #9170

Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
Co-authored-by: Tatu Lund <tatu@vaadin.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: 4 people

vaadin-grid-flow-parent/vaadin-grid-flow/src/main/java/com/vaadin/flow/component/grid/AbstractGridMultiSelectionModel.java

@@ -224,7 +224,7 @@ public void selectAll() {
                 (Set<T>) getGrid().getDataCommunicator().getDataProvider()
                         .fetch(getGrid().getDataCommunicator().buildQuery(0,
                                 Integer.MAX_VALUE))
-                        .collect(Collectors.toSet()),
+                        .collect(Collectors.toCollection(LinkedHashSet::new)),
                 Collections.emptySet());
         selectionColumn.setSelectAllCheckboxState(true);
         selectionColumn.setSelectAllCheckboxIndeterminateState(false);
@@ -415,7 +415,9 @@ protected void clientSelectAll() {
             allItemsStream = dataProvider.fetch(getGrid().getDataCommunicator()
                     .buildQuery(0, Integer.MAX_VALUE));
         }
-        doUpdateSelection(allItemsStream.collect(Collectors.toSet()),
+        doUpdateSelection(
+                allItemsStream
+                        .collect(Collectors.toCollection(LinkedHashSet::new)),
                 Collections.emptySet(), true);
         selectionColumn.setSelectAllCheckboxState(true);
         selectionColumn.setSelectAllCheckboxIndeterminateState(false);

vaadin-grid-flow-parent/vaadin-grid-flow/src/test/java/com/vaadin/flow/component/grid/GridMultiSelectionModelTest.java

@@ -31,7 +31,6 @@
 import java.util.function.Function;
 
 import org.junit.Before;
-import org.junit.Ignore;
 import org.junit.Test;
 import org.mockito.Mockito;
 
@@ -310,9 +309,29 @@ public void deselectAll() {
     }
 
     @Test
-    @Ignore
-    // Ignored because selectAll is not implemented yet
-    // See https://github.com/vaadin/flow/issues/2546
+    public void clientSelectAll_preservesDataProviderOrder() {
+        var model = (AbstractGridMultiSelectionModel<Person>) selectionModel;
+        model.clientSelectAll();
+
+        var value = model.getSelectedItems().stream().toList();
+
+        assertEquals(PERSON_A, value.get(0));
+        assertEquals(PERSON_B, value.get(1));
+        assertEquals(PERSON_C, value.get(2));
+    }
+
+    @Test
+    public void selectAll_preservesDataProviderOrder() {
+        selectionModel.selectAll();
+
+        var value = selectionModel.getSelectedItems().stream().toList();
+
+        assertEquals(PERSON_A, value.get(0));
+        assertEquals(PERSON_B, value.get(1));
+        assertEquals(PERSON_C, value.get(2));
+    }
+
+    @Test
     public void selectAll() {
         selectionModel.selectAll();