fix: remove child radios/checkboxes individually (#2598) (#2600)

Co-authored-by: Tomi Virkki <tomivirkki@users.noreply.github.com>

Author: vaadin-bot

vaadin-checkbox-flow-parent/vaadin-checkbox-flow-integration-tests/src/main/java/com/vaadin/flow/component/checkbox/tests/RefreshDataProviderPage.java

@@ -30,6 +30,7 @@ public class RefreshDataProviderPage extends Div {
 
     public RefreshDataProviderPage() {
         CheckboxGroup<String> group = new CheckboxGroup<>();
+        group.setLabel("Label");
         group.setId("group");
 
         List<String> items = new LinkedList<>(Arrays.asList("foo", "bar"));

vaadin-checkbox-flow-parent/vaadin-checkbox-flow-integration-tests/src/test/java/com/vaadin/flow/component/checkbox/tests/RefreshDataProviderPageIT.java

@@ -40,4 +40,16 @@ public void resetComponentOnDataProviderRefresh() {
         Assert.assertEquals("bar", radioButtons.get(0).getText());
         Assert.assertEquals("baz", radioButtons.get(1).getText());
     }
+
+    @Test
+    public void resetComponentExpectLabel() {
+        open();
+
+        findElement(By.id("reset")).click();
+
+        TestBenchElement group = $(TestBenchElement.class).id("group");
+        String label = group.findElement(By.cssSelector("label[slot='label']"))
+                .getText();
+        Assert.assertEquals("Label", label);
+    }
 }

vaadin-checkbox-flow-parent/vaadin-checkbox-flow/src/main/java/com/vaadin/flow/component/checkbox/CheckboxGroup.java

@@ -459,7 +459,9 @@ private void reset() {
         // Cache helper component before removal
         Component helperComponent = getHelperComponent();
         keyMapper.removeAll();
-        removeAll();
+        // Remove all known children (doesn't remove client-side-only children
+        // such as the label)
+        getChildren().forEach(this::remove);
         clear();
 
         // reinsert helper component

vaadin-radio-button-flow-parent/vaadin-radio-button-flow-integration-tests/src/main/java/com/vaadin/flow/component/radiobutton/tests/RefreshItemsPage.java

@@ -29,6 +29,7 @@ public class RefreshItemsPage extends Div {
 
     public RefreshItemsPage() {
         RadioButtonGroup<String> group = new RadioButtonGroup<>();
+        group.setLabel("Label");
         group.setId("group");
 
         List<String> items = new LinkedList<>(Arrays.asList("foo", "bar"));

vaadin-radio-button-flow-parent/vaadin-radio-button-flow-integration-tests/src/test/java/com/vaadin/flow/component/radiobutton/tests/RefreshItemsPageIT.java

@@ -22,6 +22,7 @@
 import org.openqa.selenium.By;
 
 import com.vaadin.tests.AbstractComponentIT;
+import com.vaadin.flow.component.radiobutton.testbench.RadioButtonGroupElement;
 import com.vaadin.flow.testutil.TestPath;
 import com.vaadin.testbench.TestBenchElement;
 
@@ -40,4 +41,17 @@ public void resetComponentOnItemRefresh() {
         Assert.assertEquals("bar", radioButtons.get(0).getText());
         Assert.assertEquals("baz", radioButtons.get(1).getText());
     }
+
+    @Test
+    public void resetComponentExpectLabel() {
+        open();
+
+        findElement(By.id("reset")).click();
+
+        RadioButtonGroupElement group = $(RadioButtonGroupElement.class)
+                .id("group");
+        String label = group.findElement(By.cssSelector("label[slot='label']"))
+                .getText();
+        Assert.assertEquals("Label", label);
+    }
 }

vaadin-radio-button-flow-parent/vaadin-radio-button-flow/src/main/java/com/vaadin/flow/component/radiobutton/RadioButtonGroup.java

@@ -421,7 +421,9 @@ private void reset() {
         // Cache helper component before removal
         Component helperComponent = getHelperComponent();
         keyMapper.removeAll();
-        removeAll();
+        // Remove all known children (doesn't remove client-side-only children
+        // such as the label)
+        getChildren().forEach(this::remove);
         clear();
 
         // reinsert helper component