-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge from master #5302
Merge from master #5302
Conversation
* Update byte buddy version Fixes #4956
* Add m2e lifecycle mapping for maven-antrun-plugin
* Shortcuts no longer work, when element is disabled
* Document the fact that a component with a parent will be added to a new parent and removed from the previous one.
* Add some configuration for surefire plugin Due to issues with tests run under Windows 10 we need to add the trimStackTrace and reuseForks configurations also to the surefire plugin * Also update the surefire and failsafe plugins.
Introduces ValueChangeMode#LAZY, and #TIMEOUT for delayed value synchronization to the server and makes Input implement HasValueChangeMode.
Check the function presence before calling it and take care about children property as well. Fixes #5206
public void updateValue(Serializable newValue) { | ||
if (isReadOnly()) { | ||
LoggerFactory.getLogger(WebComponentBindingImpl.class) | ||
.warn(String.format("An attempt was made to write to " + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public interface WebComponent<C extends Component> extends Serializable { | ||
void fireEvent(String eventName); | ||
|
||
void fireEvent(String eventName, JsonValue objectData); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
void fireEvent(String eventName, JsonValue objectData); | ||
|
||
void fireEvent(String eventName, JsonValue objectData, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
void fireEvent(String eventName, JsonValue objectData, | ||
EventOptions options); | ||
|
||
<P extends Serializable> void setProperty( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
import elemental.json.JsonValue; | ||
|
||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<P extends Serializable> void setProperty( | ||
PropertyConfiguration<C, P> propertyConfiguration, P value); | ||
|
||
<P extends Serializable> P getProperty(PropertyConfiguration<C, P> propertyConfiguration); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* @param <C> {@code component} being exported | ||
*/ | ||
public interface WebComponent<C extends Component> extends Serializable { | ||
void fireEvent(String eventName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* tag name of the web component | ||
* @return {@link WebComponentConfigurationImpl} by the tag | ||
*/ | ||
protected WebComponentConfigurationImpl<? extends Component> getConfigurationInternal(String tag) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* @param <T> component | ||
* @return set of {@link WebComponentConfiguration} or an empty set. | ||
*/ | ||
public <T extends Component> Set<WebComponentConfiguration<T>> getConfigurationsByComponentType(Class<T> componentClass) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* custom element tag | ||
* @return Optional containing a web component matching given tag | ||
*/ | ||
public Optional<WebComponentConfiguration<? extends Component>> getConfiguration(String tag) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assert servletContext != null; | ||
|
||
Object attribute; | ||
synchronized (servletContext) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} | ||
} | ||
|
||
private static WebComponentConfigurationRegistry createRegistry(ServletContext context) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} | ||
} | ||
|
||
protected WebComponentConfigurationImpl<? extends Component> constructConfigurations( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* | ||
* @return unmodifiable set of web component builders in registry | ||
*/ | ||
public Set<WebComponentConfiguration<? extends Component>> getConfigurations() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SonarQube analysis reported 43 issues Watch the comments in this conversation to review them. 10 extra issuesNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 58 of 58 files at r1.
Reviewable status: 33 unresolved discussions, 1 of 1 LGTMs obtained (waiting on @caalador)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dismissed @vaadin-bot from 33 discussions.
Reviewable status: complete! all discussions resolved, 1 of 1 LGTMs obtained
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all discussions resolved, 2 of 1 LGTMs obtained
Merge master to 2.0
This change is