Skip to content

refactor!: remove generated Lumo CSS files #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

refactor!: remove generated Lumo CSS files #346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0532371
refactor!: remove generated Lumo CSS files
web-padawan Aug 6, 2025
2395918
chore: remove check for validating CSS build
web-padawan Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion dev/kitchen-sink/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { useState } from 'react';
import '../../packages/react-components/css/lumo/Typography.css';
import { AppLayout } from '../../packages/react-components/src/AppLayout.js';
import { Avatar } from '../../packages/react-components/src/Avatar.js';
import { Board } from '../../packages/react-components-pro/src/Board.js';
Expand Down
16 changes: 1 addition & 15 deletions packages/react-components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,8 @@
},
"scripts": {
"build": "npm run build:dev && npm run build:code && npm run build:update-packagejson",
"build:dev": "npm run build:generate && npm run build:generate-css",
"build:dev": "npm run build:generate",
"build:generate": "tsx ../../scripts/generator.ts",
"build:generate-css": "tsx --experimental-vm-modules ../../scripts/css-generator.ts",
"build:update-packagejson": "tsx ../../scripts/package-json-update.ts",
"build:code": "concurrently npm:build:code:*",
"build:code:ts": "tsx ../../scripts/build.ts",
Expand Down Expand Up @@ -476,19 +475,6 @@
"./Upload": "./Upload.js",
"./VerticalLayout": "./VerticalLayout.js",
"./VirtualList": "./VirtualList.js",
"./css/Lumo.css": "./css/Lumo.css",
"./css/lumo/Badge.css": "./css/lumo/Badge.css",
"./css/lumo/Color.css": "./css/lumo/Color.css",
"./css/lumo/ColorBase.css": "./css/lumo/ColorBase.css",
"./css/lumo/Font.css": "./css/lumo/Font.css",
"./css/lumo/FontIcons.css": "./css/lumo/FontIcons.css",
"./css/lumo/Globals.css": "./css/lumo/Globals.css",
"./css/lumo/Sizing.css": "./css/lumo/Sizing.css",
"./css/lumo/Spacing.css": "./css/lumo/Spacing.css",
"./css/lumo/Style.css": "./css/lumo/Style.css",
"./css/lumo/Typography.css": "./css/lumo/Typography.css",
"./css/lumo/UserColors.css": "./css/lumo/UserColors.css",
"./css/lumo/Utility.module.css": "./css/lumo/Utility.module.css",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While loading Lumo is otherwise a one-liner, this utility module could cause a lot of changes as using it would leave references all over the codebase. Let's discuss with the team how to proceed with it.

There also needs to be a note about removing the CSS files from this package in the upgrade guide.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, makes sense. I wanted to remove it mainly so we could drop Lumo JS eventually (as these CSS files are generated from JS modules that are still present although not supposed to be used anymore).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One option would be to just put the current version of that file in the repo. Not sure how we would mark it as deprecated though. But again, let's discuss options first.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #358 as an alternative.

"./utils/createComponent.d.ts": "./utils/createComponent.d.ts",
"./utils/createComponent.d.ts.map": "./utils/createComponent.d.ts.map",
"./utils/createComponent.js": "./utils/createComponent.js",
Expand Down
351 changes: 0 additions & 351 deletions scripts/css-generator.ts
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions scripts/utils/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,3 @@ export const srcURL = pathToFileURL(`${srcDir}/`);
export const generatedURL = pathToFileURL(`${generatedDir}/`);

await Promise.all([mkdir(generatedDir, { recursive: true }), mkdir(typesDir, { recursive: true })]);

export const stylePackages = ['@vaadin/vaadin-lumo-styles'];
Loading