feat: don't ignore endpoint request for Spring csrf check #908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haprog
approved these changes
Oct 11, 2021
platosha
reviewed
Oct 11, 2021
| private logout() { | ||
| logout(); | ||
| private async logout() { | ||
| await logout(); |
There was a problem hiding this comment.
Endpoint calls might be rejected for invalid CSRF during the brief period between the logout request and the logout response, which updates the CSRF token. This was causing an error in IT test.
The UI should await until the logout resolves before navigating to the logout success location.
Collaborator
|
This ticket/PR has been released with platform 22.0.0.alpha7 and is also targeting the upcoming stable 22.0.0 version. |
manolo
pushed a commit
to vaadin/flow
that referenced
this pull request
Feb 8, 2022
vaadin/spring#908 * feat: don't ignore endpoint request for Spring csrf check * Fix: await for logout in IT test application Co-authored-by: Anton Platonov <anton@vaadin.com> Co-authored-by: Zhe Sun <31067185+ZheSun88@users.noreply.github.com> Co-authored-by: Anton Platonov <platosha@gmail.com>
manolo
pushed a commit
to vaadin/flow
that referenced
this pull request
Feb 8, 2022
vaadin/spring#908 * feat: don't ignore endpoint request for Spring csrf check * Fix: await for logout in IT test application Co-authored-by: Anton Platonov <anton@vaadin.com> Co-authored-by: Zhe Sun <31067185+ZheSun88@users.noreply.github.com> Co-authored-by: Anton Platonov <platosha@gmail.com>
platosha
added a commit
to vaadin/hilla
that referenced
this pull request
May 24, 2022
vaadin/spring#908 * feat: don't ignore endpoint request for Spring csrf check * Fix: await for logout in IT test application Co-authored-by: Anton Platonov <anton@vaadin.com> Co-authored-by: Zhe Sun <31067185+ZheSun88@users.noreply.github.com> Co-authored-by: Anton Platonov <platosha@gmail.com>
platosha
added a commit
to vaadin/hilla
that referenced
this pull request
May 31, 2022
vaadin/spring#908 * feat: don't ignore endpoint request for Spring csrf check * Fix: await for logout in IT test application Co-authored-by: Anton Platonov <anton@vaadin.com> Co-authored-by: Zhe Sun <31067185+ZheSun88@users.noreply.github.com> Co-authored-by: Anton Platonov <platosha@gmail.com>
vercel-talented
added a commit
to vercel-talented/hilla-react
that referenced
this pull request
May 4, 2024
vaadin/spring#908 * feat: don't ignore endpoint request for Spring csrf check * Fix: await for logout in IT test application Co-authored-by: Anton Platonov <anton@vaadin.com> Co-authored-by: Zhe Sun <31067185+ZheSun88@users.noreply.github.com> Co-authored-by: Anton Platonov <platosha@gmail.com>
byte-dev-hubs
added a commit
to byte-dev-hubs/hila-java
that referenced
this pull request
May 12, 2024
vaadin/spring#908 * feat: don't ignore endpoint request for Spring csrf check * Fix: await for logout in IT test application Co-authored-by: Anton Platonov <anton@vaadin.com> Co-authored-by: Zhe Sun <31067185+ZheSun88@users.noreply.github.com> Co-authored-by: Anton Platonov <platosha@gmail.com>
AceDev24
pushed a commit
to AceDev24/hiliaGround
that referenced
this pull request
Sep 3, 2024
vaadin/spring#908 * feat: don't ignore endpoint request for Spring csrf check * Fix: await for logout in IT test application Co-authored-by: Anton Platonov <anton@vaadin.com> Co-authored-by: Zhe Sun <31067185+ZheSun88@users.noreply.github.com> Co-authored-by: Anton Platonov <platosha@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on vaadin/hilla#116 and vaadin/flow#11922, related to vaadin/hilla#12