fix: Take into account that a VaadinSession can be detached from the HTTP session #911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artur-
changed the title
denis-anisimov
suggested changes
Oct 5, 2021
| private Optional<SecurityContext> getFromVaadinSession() { | ||
| VaadinSession session = VaadinSession.getCurrent(); | ||
| if (session == null) { | ||
| if (session == null || session.getSession() == null) { |
There was a problem hiding this comment.
tests ?
This can be easily revert back by someone accidentally without a test and no-one notice this ever
denis-anisimov
approved these changes
Oct 7, 2021
Collaborator
|
This ticket/PR has been released with platform 22.0.0.alpha7 and is also targeting the upcoming stable 22.0.0 version. |
manolo
pushed a commit
to vaadin/flow
that referenced
this pull request
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #910