Make vaadin.blacklisted-packages specifiable with packages #935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Artur-
reviewed
Nov 17, 2021
| } else { | ||
| neverScan = Arrays.stream(neverScanProperty.split(",")) | ||
| .map(String::trim).collect(Collectors.toList()); | ||
| .map(onlyFolder -> onlyFolder.replace('.', '/').trim()) |
Member
There was a problem hiding this comment.
onlyFolder - what does that refer to?
Contributor
Author
There was a problem hiding this comment.
To use the folder instead of package (to be symmetrical to how onlyPackages is used with vaadin.whitelisted-packages)
Contributor
Author
There was a problem hiding this comment.
Though I now realize that "only" probably refers to the inclusion criterion of whitelisted packages.
Artur-
approved these changes
Nov 18, 2021
Collaborator
|
SonarQube analysis reported 21 issues
Top 10 issues
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike
vaadin.whitelisted-packageswhich can be specified with both '.' and '/',vaadin.blacklisted-packagesonly works with '/'.This is suboptimal, as rightly noted in this issue, because packages use . not /.