refactor: align updatePart parameter order with other methods (#10481)

Author: vursen

packages/grid-pro/src/vaadin-grid-pro-inline-editing-mixin.js

@@ -553,7 +553,7 @@ export const InlineEditingMixin = (superClass) =>
       iterateRowCells(row, (cell) => {
         const isEditable = !row.hasAttribute('loading') && this._isCellEditable(cell);
         const target = cell._focusButton || cell;
-        updatePart(target, isEditable, 'editable-cell');
+        updatePart(target, 'editable-cell', isEditable);
       });
     }
 

packages/grid/src/vaadin-grid-helpers.js

@@ -81,10 +81,10 @@ export function updateState(element, attribute, value) {
 
 /**
  * @param {!HTMLElement} element
- * @param {boolean | string | null | undefined} value
  * @param {string} part
+ * @param {boolean | string | null | undefined} value
  */
-export function updatePart(element, value, part) {
+export function updatePart(element, part, value) {
   if (value || value === '') {
     addValueToAttribute(element, 'part', part);
   } else {
@@ -99,7 +99,7 @@ export function updatePart(element, value, part) {
  */
 export function updateCellsPart(cells, part, value) {
   cells.forEach((cell) => {
-    updatePart(cell, value, part);
+    updatePart(cell, part, value);
   });
 }
 
@@ -117,7 +117,7 @@ export function updateBooleanRowStates(row, states) {
     const rowPart = `${state}-row`;
 
     // Row part attribute
-    updatePart(row, value, rowPart);
+    updatePart(row, rowPart, value);
 
     // Cells part attribute
     updateCellsPart(cells, `${rowPart}-cell`, value);
@@ -140,14 +140,14 @@ export function updateStringRowStates(row, states) {
     // remove previous part from row and cells if there was any
     if (prevValue) {
       const prevRowPart = `${state}-${prevValue}-row`;
-      updatePart(row, false, prevRowPart);
+      updatePart(row, prevRowPart, false);
       updateCellsPart(cells, `${prevRowPart}-cell`, false);
     }
 
     // set new part to rows and cells if there is a value
     if (value) {
       const rowPart = `${state}-${value}-row`;
-      updatePart(row, value, rowPart);
+      updatePart(row, rowPart, value);
       updateCellsPart(cells, `${rowPart}-cell`, value);
     }
   });
@@ -166,11 +166,11 @@ export function updateCellState(cell, attribute, value, part, oldPart) {
 
   // Remove old part from the attribute
   if (oldPart) {
-    updatePart(cell, false, oldPart);
+    updatePart(cell, oldPart, false);
   }
 
   // Add new part to the cell attribute
-  updatePart(cell, value, part || `${attribute}-cell`);
+  updatePart(cell, part || `${attribute}-cell`, value);
 }
 
 /**

packages/grid/src/vaadin-grid-mixin.js

@@ -757,12 +757,12 @@ export const GridMixin = (superClass) =>
     __updateHeaderFooterRowParts(section) {
       const visibleRows = [...this.$[section].querySelectorAll('tr:not([hidden])')];
       [...this.$[section].children].forEach((row) => {
-        updatePart(row, row === visibleRows.at(0), `first-${section}-row`);
-        updatePart(row, row === visibleRows.at(-1), `last-${section}-row`);
+        updatePart(row, `first-${section}-row`, row === visibleRows.at(0));
+        updatePart(row, `last-${section}-row`, row === visibleRows.at(-1));
 
         getBodyRowCells(row).forEach((cell) => {
-          updatePart(cell, row === visibleRows.at(0), `first-${section}-row-cell`);
-          updatePart(cell, row === visibleRows.at(-1), `last-${section}-row-cell`);
+          updatePart(cell, `first-${section}-row-cell`, row === visibleRows.at(0));
+          updatePart(cell, `last-${section}-row-cell`, row === visibleRows.at(-1));
         });
       });
     }

packages/grid/src/vaadin-grid-styling-mixin.js

@@ -131,7 +131,7 @@ export const StylingMixin = (superClass) =>
         if (cell.__generatedParts) {
           cell.__generatedParts.forEach((partName) => {
             // Remove previously generated part names
-            updatePart(cell, null, partName);
+            updatePart(cell, partName, null);
           });
         }
         if (this.cellPartNameGenerator && !row.hasAttribute('loading')) {
@@ -140,7 +140,7 @@ export const StylingMixin = (superClass) =>
           if (cell.__generatedParts) {
             cell.__generatedParts.forEach((partName) => {
               // Add the newly generated names to part
-              updatePart(cell, true, partName);
+              updatePart(cell, partName, true);
             });
           }
         }