Skip to content

Commit ffb4fca

Browse files
authored
fix: overlay text color with dark and mixed color schemes (#11265)
1 parent 93fa780 commit ffb4fca

File tree

148 files changed

+32
-1
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

148 files changed

+32
-1
lines changed

dev/aura/components-view.js

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import '@vaadin/checkbox';
55
import '@vaadin/checkbox-group';
66
import '@vaadin/combo-box';
77
import '@vaadin/date-time-picker';
8+
import '@vaadin/confirm-dialog';
89
import '@vaadin/grid';
910
import '@vaadin/grid/src/vaadin-grid-selection-column.js';
1011
import '@vaadin/horizontal-layout';
@@ -212,6 +213,19 @@ function initView(view) {
212213
grid.querySelector('vaadin-grid-column.avatar').renderer = (root, _, model) => {
213214
root.innerHTML = `<vaadin-avatar name="${model.item.name}" color-index="${model.index % 9}"></vaadin-avatar>`;
214215
};
216+
217+
// Confirm Dialog
218+
view.querySelector('#open-confirm-dialog').addEventListener('click', () => {
219+
const temp = document.createElement('div');
220+
temp.innerHTML = `<vaadin-confirm-dialog id="confirm-dialog-example" header="Unsaved Changes" confirm-text="Save" reject-text="Discard"
221+
cancel-button-visible reject-button-visible>
222+
Do you want to save or discard the changes? That is the question. But whatever you choose, there will be no
223+
consequences.
224+
</vaadin-confirm-dialog>`;
225+
const dialog = temp.firstElementChild;
226+
document.body.append(dialog);
227+
dialog.opened = true;
228+
});
215229
}
216230

217231
customElements.define(
@@ -473,6 +487,10 @@ customElements.define(
473487
</vaadin-tabs>
474488
</div>
475489
490+
<div class="aura-surface component">
491+
<vaadin-button id="open-confirm-dialog">Open Dialog</vaadin-button>
492+
</div>
493+
476494
<div class="aura-surface component wide">
477495
<vaadin-date-time-picker style="width: 20em" value="2025-09-09T12:00"></vaadin-date-time-picker>
478496
</div>

packages/aura/src/color.css

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,10 @@ vaadin-badge,
5959
vaadin-button,
6060
vaadin-upload-button,
6161
vaadin-context-menu-item,
62+
vaadin-confirm-dialog,
6263
vaadin-crud-edit,
6364
vaadin-drawer-toggle,
65+
vaadin-dialog,
6466
vaadin-menu-bar-button,
6567
vaadin-menu-bar-item,
6668
vaadin-message::part(attachment),
15 Bytes
73 Bytes
13 Bytes
89 Bytes
44 Bytes
-1 Bytes
75 Bytes

packages/confirm-dialog/src/vaadin-confirm-dialog.d.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ export * from './vaadin-confirm-dialog-mixin.js';
4646
* |`--vaadin-dialog-border-width` |
4747
* |`--vaadin-dialog-padding` |
4848
* |`--vaadin-dialog-shadow` |
49+
* |`--vaadin-dialog-text-color` |
4950
* |`--vaadin-dialog-title-color` |
5051
* |`--vaadin-dialog-title-font-size` |
5152
* |`--vaadin-dialog-title-font-weight` |

0 commit comments

Comments
 (0)